Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null values applied to filters with empty values in custom url from Click Behavior #38489

Closed
FilmonK opened this issue Feb 6, 2024 · 0 comments · Fixed by #40023
Closed

Null values applied to filters with empty values in custom url from Click Behavior #38489

FilmonK opened this issue Feb 6, 2024 · 0 comments · Fixed by #40023
Assignees
Labels
Priority:P2 Average run of the mill bug Reporting/Dashboards/Click Behavior .Team/DashViz Dashboard and Viz team Type:Bug Product defects
Milestone

Comments

@FilmonK
Copy link

FilmonK commented Feb 6, 2024

Describe the bug

Null values are being applied to filters with empty values in custom urls generated from Click Behavior functionality.

To Reproduce

1.) Create a basic query and attach to a dashboard.

SELECT *
FROM player_salary
WHERE {{team}}
  AND {{seasonID}}


2.) Create Click Behavior action from the dashboard that's going to a url with these parameters (team, seasonID) passed in.

1.48.5
Null is automatically being applied even though nothing was selected for the ‘seasonID’ filter.

Screenshot 2024-02-06 at 2 31 26 PM Screenshot 2024-02-06 at 2 32 14 PM

1.47.9
‘seasonID’ isn't passed into the url since no filter values have been selected.
Screenshot 2024-02-06 at 2 34 51 PM

Screenshot 2024-02-06 at 2 36 47 PM

Expected behavior

Results similar to 47 version as having a null value for a filter would produce unexpected results

Logs

No response

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.22+7",
    "java.vendor": "Eclipse Adoptium",
    "java.vendor.url": "https://adoptium.net/",
    "java.version": "11.0.22",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.22+7",
    "os.name": "Linux",
    "os.version": "5.15.49-linuxkit-pr",
    "user.language": "en",
    "user.timezone": "GMT"
  },
  "metabase-info": {
    "databases": [
      "mongo",
      "h2",
      "mysql",
      "postgres",
      "bigquery-cloud-sdk"
    ],
    "hosting-env": "unknown",
    "application-database": "postgres",
    "application-database-details": {
      "database": {
        "name": "PostgreSQL",
        "version": "15.3"
      },
      "jdbc-driver": {
        "name": "PostgreSQL JDBC Driver",
        "version": "42.6.0"
      }
    },
    "run-mode": "prod",
    "version": {
      "date": "2024-02-06",
      "tag": "v1.48.5",
      "hash": "dab12cf"
    },
    "settings": {
      "report-timezone": "America/Los_Angeles"
    }
  }
}

Severity

P2 - Results similar to 47 version as having a null value for a filter would produce unexpected results

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P2 Average run of the mill bug Reporting/Dashboards/Click Behavior .Team/DashViz Dashboard and Viz team Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants