Fix null values being applied to filters with click behavior custom URL links #40023
+85
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseSDevaney
added
backport
|
kulyk
requested changes
Mar 18, 2024
kulyk
approved these changes
Mar 19, 2024
JesseSDevaney
deleted the
38489/fix-null-values-applied-in-custom-url-click-behavior
branch
|
@JesseSDevaney Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
…RL links (#40023) * do not pass null values to link url * update null check to include query builder nulls replaced with "(empty") * add test to verify behavior * replace magic string with constant * fix breakout in cypress spec
metabase-bot bot
added a commit
that referenced
this pull request
Mar 19, 2024
…RL links (#40023) (#40323) * do not pass null values to link url * update null check to include query builder nulls replaced with "(empty") * add test to verify behavior * replace magic string with constant * fix breakout in cypress spec Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
calherries
pushed a commit
that referenced
this pull request
Mar 21, 2024
…RL links (#40023) * do not pass null values to link url * update null check to include query builder nulls replaced with "(empty") * add test to verify behavior * replace magic string with constant * fix breakout in cypress spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
2024-03-12.13-35-14.mp4
After
2024-03-12.13-36-52.mp4