Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV upload fails on rows with float type among mostly integer values #38958

Closed
Tracked by #38853
calherries opened this issue Feb 20, 2024 · 2 comments
Closed
Tracked by #38853
Assignees
Labels
.Team/BackendComponents also known as BEC
Milestone

Comments

@calherries
Copy link
Contributor

calherries commented Feb 20, 2024

https://metaboat.slack.com/archives/C04S696LRUM/p1707242309280519?thread_ts=1707238777.488509&cid=C04S696LRUM

@calherries calherries changed the title https://metaboat.slack.com/archives/C04S696LRUM/p1707242309280519?thread_ts=1707238777.488509&cid=C04S696LRUM CSV upload fails on rows with float type among mostly integer values Feb 20, 2024
@crisptrutski
Copy link
Contributor

I think that the issue here is that we infer the schema based on a subset of the rows, and are missing the sparse float values.

The solution for this will build on #37069

@crisptrutski
Copy link
Contributor

The issue was indeed the row sampling.

With the optimized inference method there's no longer any need to do the sampling, and the reference file loads correctly.

The merge for the fix is just waiting behind the implicit int to float column promotion PR.

@crisptrutski crisptrutski self-assigned this Mar 7, 2024
@crisptrutski crisptrutski added the .Team/BackendComponents also known as BEC label Mar 7, 2024
@crisptrutski crisptrutski added this to the 0.50 milestone Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Team/BackendComponents also known as BEC
Projects
None yet
Development

No branches or pull requests

2 participants