Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV appends: integer columns should be convertable to float #37069

Closed
1 task done
Tracked by #38853
calherries opened this issue Dec 22, 2023 · 2 comments · Fixed by #39493
Closed
1 task done
Tracked by #38853

CSV appends: integer columns should be convertable to float #37069

calherries opened this issue Dec 22, 2023 · 2 comments · Fixed by #39493
Assignees
Labels
Organization/Uploads Direct data upload (CSV) .Team/BackendComponents also known as BEC
Milestone

Comments

@calherries
Copy link
Contributor

calherries commented Dec 22, 2023

Integer columns in an upload table should be converted to a floating-point type if the uploaded column in the CSV file contains a floating-point number.

  • Test: if a column is an integer type, uploading a single float should convert the column to float
@ojjj13
Copy link

ojjj13 commented Dec 27, 2023

In the same manner a column should converted to int/float when it has one, when I was uploading csv to metabase I always get "xx is not a boolean value" with a column start with a bunch of 0 and 1s follow by a random number.

@calherries calherries changed the title CSV appends: integer columns should be converted to float CSV appends: boolean/integer columns should be converted to float, and boolean columns should be converted to integer Jan 22, 2024
@calherries calherries changed the title CSV appends: boolean/integer columns should be converted to float, and boolean columns should be converted to integer CSV appends: integer columns should be convertable to float Jan 22, 2024
@calherries calherries removed the .Task Not a part of any Epic, used by the Task Issue Template label Jan 26, 2024
@calherries calherries self-assigned this Jan 26, 2024
@calherries
Copy link
Contributor Author

Some slack discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Organization/Uploads Direct data upload (CSV) .Team/BackendComponents also known as BEC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants