Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive embedding dashboard with multiple tabs and parameter header=false will not load #39002

Closed
WiNloSt opened this issue Feb 21, 2024 · 1 comment
Assignees
Labels
Embedding/Interactive Interactive Embedding, previously known as Full app embedding Priority:P2 Average run of the mill bug .Team/Embedding Type:Bug Product defects
Milestone

Comments

@WiNloSt
Copy link
Member

WiNloSt commented Feb 21, 2024

Describe the bug

I found this bug while reproducing #38429

In interactive embedding, if you visit a dashboard that has multiple tabs and has the parameter header=false, the dashboard will not finish loading

image

To Reproduce

  1. Set up interactive embedding
  2. Create a dashboard with multiple tabs
  3. Visit the interactive embedding page where the iframe URL has this parameter ?header=false
  4. Visit the dashboard we created in 1)
  5. See that the card will not stop spinning. In fact the card requests will never be initiated.

Expected behavior

The dashboard loads normally

Logs

No response

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.14.1+1-LTS",
    "java.vendor": "Azul Systems, Inc.",
    "java.vendor.url": "http://www.azul.com/",
    "java.version": "11.0.14.1",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.14.1+1-LTS",
    "os.name": "Mac OS X",
    "os.version": "14.2.1",
    "user.language": "en",
    "user.timezone": "Asia/Bangkok"
  },
  "metabase-info": {
    "databases": [
      "h2",
      "postgres"
    ],
    "hosting-env": "unknown",
    "application-database": "h2",
    "application-database-details": {
      "database": {
        "name": "H2",
        "version": "2.1.214 (2022-06-13)"
      },
      "jdbc-driver": {
        "name": "H2 JDBC Driver",
        "version": "2.1.214 (2022-06-13)"
      }
    },
    "run-mode": "dev",
    "version": {
      "date": "2024-02-20",
      "src_hash": "e3b554bc3d8e4448572d8fdde9681523aca052d8",
      "tag": "v0.48.1-SNAPSHOT",
      "hash": "11823a5"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity

Almost blocking? Users can remove header=false to mitigate the issue.

Additional context

No response

@WiNloSt WiNloSt added Type:Bug Product defects .Needs Triage .Team/Embedding Embedding/Interactive Interactive Embedding, previously known as Full app embedding labels Feb 21, 2024
@albertoperdomo albertoperdomo added the Priority:P2 Average run of the mill bug label Feb 21, 2024
@albertoperdomo
Copy link
Member

P2 as it prevents people from using tabs together w/ interactive embedding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embedding/Interactive Interactive Embedding, previously known as Full app embedding Priority:P2 Average run of the mill bug .Team/Embedding Type:Bug Product defects
Projects
None yet
2 participants