Fix can't select dashboard tabs in interactive embedding with parameter header=false
#39007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiNloSt
commented
Feb 21, 2024
| /> | ||
| </DashboardHeaderContainer> | ||
| )} | ||
| <DashboardHeaderContainer |
There was a problem hiding this comment.
Pro tip: Use the hide whitespace option for EZ review.
| data-testid="fixed-width-dashboard-header" | ||
| isNavBarOpen={isNavBarOpen} | ||
| isFixedWidth={dashboard?.width === "fixed"} | ||
| {isDashboardHeaderVisible && ( |
There was a problem hiding this comment.
Only hide the part before the dashboard tabs, because the dashboard tabs should always be visible.
1 task
WiNloSt
added
the
backport
|
kulyk
approved these changes
Feb 21, 2024
albertoperdomo
approved these changes
Feb 21, 2024
WiNloSt
deleted the
38429-fix-interactive-embedding-with-header-false-can-not-change-tabs
branch
|
@WiNloSt Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
WiNloSt
added a commit
that referenced
this pull request
Feb 22, 2024
…er `header=false` (#39007) * Remove full-app to a newer term * Fix dashboard not loading in interactive embedding with header=false header=false * Fix can't choose dashboard tabs in interactive embedding w/ header=false
|
@albertoperdomo Feel free to open an issue for that too. I remember we haven't talked about hiding that banner specifically in embedding, we only talked about hiding that database prompt banner when users are whitelabeling. That feels to me we should do that for interactive embedding as well, since interactive embedding is also closely related to whitelabeling. |
|
@metabase-bot backport release-x.48.x |
WiNloSt
added a commit
that referenced
this pull request
Mar 15, 2024
…er `header=false` (#39007) * Remove full-app to a newer term * Fix dashboard not loading in interactive embedding with header=false header=false * Fix can't choose dashboard tabs in interactive embedding w/ header=false
WiNloSt
added a commit
that referenced
this pull request
Mar 15, 2024
…er `header=false` (#39007) * Remove full-app to a newer term * Fix dashboard not loading in interactive embedding with header=false header=false * Fix can't choose dashboard tabs in interactive embedding w/ header=false
WiNloSt
added a commit
that referenced
this pull request
Mar 15, 2024
* Fix can't select dashboard tabs in interactive embedding with parameter `header=false` (#39007) * Remove full-app to a newer term * Fix dashboard not loading in interactive embedding with header=false header=false * Fix can't choose dashboard tabs in interactive embedding w/ header=false * Fix failed tests
npretto
reviewed
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR supersedes #39005
Closes #38429, #39002
Description
The
headerdocumentation indicatesDashboard tabs is a very crucial part of the dashboard and should, in my opinion, never been hidden.
This PR fixes the problem by only hiding the other parts in the dashboard header except the tabs
Note Please also see the #39005 explaining the fix for the dashboard card not loading which is also fixed in this PR with a different approach.
How to verify
?header=falseDemo
Before
After
Checklist