Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date Filter : Next | Previous (Week/Month/etc) can't be set at 2 (0.21.0) #3910

Closed
romone22 opened this issue Dec 9, 2016 · 4 comments
Closed

Date Filter : Next | Previous (Week/Month/etc) can't be set at 2 (0.21.0) #3910

romone22 opened this issue Dec 9, 2016 · 4 comments
Assignees
@camsaul
Labels
Querying/Processor Type:Bug Product defects
Milestone
0.22.0

Comments

@romone22
Copy link

romone22 commented Dec 9, 2016

Hi,

It seams the offset for the NEXT / PREVIOUS Date filter is not right between 1 and 2.

It's actually not possible to filter on the last 2 months for instance. Cf Screenshot

screen shot 2016-12-09 at 9 56 23 am

screen shot 2016-12-09 at 9 56 13 am

screen shot 2016-12-09 at 9 56 01 am

screen shot 2016-12-09 at 9 55 47 am
@tlrobinson
Copy link
Contributor

Possibly a duplicate of #3731

@salsakran
Copy link
Contributor

salsakran commented Dec 10, 2016 •
edited
Loading

@camsaul I've repro'd this on the sample dataset.

@camsaul camsaul added the Type:Bug Product defects label Dec 10, 2016
@camsaul camsaul self-assigned this Jan 9, 2017
@camsaul
Copy link
Member

camsaul commented Jan 9, 2017

Ok I see why this is happening. SQL BETWEEN is inclusive and the SQL looks like

SELECT ...
WHERE created_at BETWEEN [3 months ago] AND [1 month ago]
...

The SQL should actually be BETWEEN [2 months ago] AND [1 month ago].

@camsaul camsaul added this to the 0.22.0 milestone Jan 9, 2017
camsaul added a commit that referenced this issue Jan 9, 2017
@camsaul
Failing tests for #3910
f269f73
@camsaul camsaul mentioned this issue Jan 9, 2017
Merged
@camsaul
Copy link
Member

camsaul commented Jan 9, 2017

Fixed by #4101

@camsaul camsaul closed this as completed Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camsaul camsaul

Labels
Querying/Processor Type:Bug Product defects
Projects
None yet
Milestone
0.22.0
Development

No branches or pull requests
4 participants
@tlrobinson @salsakran @camsaul @romone22