Add the timestamp to the filename in the subscription attachment #39120
Assignees
Labels
good first issue
A starter issue that is good for someone new to the codebase or is a new contributor
Reporting/Export
Reporting/Pulses
Now called Subscriptions
.Team/DashViz
Dashboard and Viz team
Type:New Feature
Milestone
Comments
paoliniluis
added
Reporting/Pulses
|
I'm looking for a first issue to contribute. @paoliniluis do you have more context on this? |
adam-james-v
added a commit
that referenced
this issue
Mar 5, 2024
Fixes: #39120 This modifies the subscriptin attachment filenames to match the same format used when doing a direct download from a dashboard or question. That is: - card names are slugified (spaces and dashes turned to underscores, etc.) - a timestamp is appended to the slugified card name
adam-james-v
added a commit
that referenced
this issue
Mar 6, 2024
* Use timestamp in attachment filenames Fixes: #39120 This modifies the subscriptin attachment filenames to match the same format used when doing a direct download from a dashboard or question. That is: - card names are slugified (spaces and dashes turned to underscores, etc.) - a timestamp is appended to the slugified card name * Fix tests * Change docstring to use example local to the namespace
github-actions bot
pushed a commit
that referenced
this issue
Mar 6, 2024
* Use timestamp in attachment filenames Fixes: #39120 This modifies the subscriptin attachment filenames to match the same format used when doing a direct download from a dashboard or question. That is: - card names are slugified (spaces and dashes turned to underscores, etc.) - a timestamp is appended to the slugified card name * Fix tests * Change docstring to use example local to the namespace
metabase-bot bot
added a commit
that referenced
this issue
Mar 6, 2024
* Use timestamp in attachment filenames Fixes: #39120 This modifies the subscriptin attachment filenames to match the same format used when doing a direct download from a dashboard or question. That is: - card names are slugified (spaces and dashes turned to underscores, etc.) - a timestamp is appended to the slugified card name * Fix tests * Change docstring to use example local to the namespace Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
We should make all exports have the same naming convention: question_name_timestamp.format. Right now normal exports have this, while the attachments on the subscriptions do not
Describe the solution you'd like
Add the timestamp to the subscription attachments
Describe alternatives you've considered
None
How important is this feature to you?
Requested by a lead
Additional context
NA
The text was updated successfully, but these errors were encountered: