Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling "don't send if there aren't results" in a subscription won't send the text cards #39190

Closed
paoliniluis opened this issue Feb 27, 2024 · 2 comments · Fixed by #39216
Closed

Enabling "don't send if there aren't results" in a subscription won't send the text cards #39190

paoliniluis opened this issue Feb 27, 2024 · 2 comments · Fixed by #39216
Assignees
@adam-james-v
Labels
.Escalation Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Pulses Now called Subscriptions Type:Bug Product defects
Milestone
0.48.9

Comments

@paoliniluis
Copy link
Contributor

Describe the bug

Enabling
image

won't send the text cards in the dashboard sub

Enabled
image

Disabled
image

The reason is that text cards don't have results and that's why #37546 wiped them

To Reproduce

  1. create a dashboard
  2. add text cards
  3. enable "don't send if there aren't results"
  4. send the test email

Expected behavior

Text cards should be always included

Logs

NA

Information about your Metabase installation

v48.6

Severity

P1

Additional context

No response
@paoliniluis paoliniluis added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Reporting/Pulses Now called Subscriptions .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Escalation labels Feb 27, 2024
@markbastian markbastian mentioned this issue Feb 27, 2024
Merged
@paoliniluis paoliniluis added this to the 0.48.8 milestone Feb 29, 2024
@Tony-metabase
Copy link
Contributor

This still happens

@Tony-metabase Tony-metabase reopened this Mar 8, 2024
@adam-james-v adam-james-v mentioned this issue Mar 9, 2024
Closed
@paoliniluis paoliniluis modified the milestones: 0.48.8, 0.48.9 Mar 11, 2024
@adam-james-v
Copy link
Contributor

The fix has been backported to x.48.x now, so this can be closed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adam-james-v adam-james-v

Labels
.Escalation Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Pulses Now called Subscriptions Type:Bug Product defects
Projects
None yet
Milestone
0.48.9
4 participants
@paoliniluis @markbastian @adam-james-v @Tony-metabase