Text cards not skipped in pulses #39216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the logic of skipping what cards are displayed in a pulse email by ensuring the type of the card being processed is a `:card` in addition to having no results.
markbastian
added
the
backport
|
|
@markbastian Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
This PR updates the logic of skipping what cards are displayed in a pulse email by ensuring the type of the card being processed is a `:card` in addition to having no results.
|
@metabase-bot backport release-x.48.x |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
This PR updates the logic of skipping what cards are displayed in a pulse email by ensuring the type of the card being processed is a `:card` in addition to having no results.
metabase-bot bot
added a commit
that referenced
this pull request
Mar 11, 2024
* Text cards not skipped in pulses (#39216) This PR updates the logic of skipping what cards are displayed in a pulse email by ensuring the type of the card being processed is a `:card` in addition to having no results. * Update test/metabase/pulse/pulse_integration_test.clj --------- Co-authored-by: Mark Bastian <markbastian@gmail.com> Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic of skipping what cards are displayed in a pulse email by ensuring the type of the card being processed is a
:cardin addition to having no results.Fixes #39190