Switching between tabs reruns queries even if filters are not modified

[ignacio-mb]

Describe the bug

Queries are being rerun when switching between tabs in 48.x, even though this is not the intended behavior (see thread)

tabs.1.mov

To Reproduce

1. Dave a dashboard with “Tab A” and “Tab B”, both tabs have questions and common filters.
2. Open “Tab A”, set some filter values and wait until things load
3. Go to “Tab B”, wait until things load
4. Go back to “Tab A”

Metabase reruns queries even though filters were not changed. This should not be happening as per this

Expected behavior

Shouldn't rerun the query if things keep unmodified

Logs

No response

Information about your Metabase installation

- V1.48.8

Severity

P2

Additional context

Happens in 48 and 47, doesn't happen in Master (49)

[ignacio-mb]

Couldn't reproduce in 49, so closing this.

[kulyk]

Update: the issue can be reproduced in 49 as well. #35465 fixed this on master but it wasn't backported to 49 (and most likely shouldn't)

[kulyk]

Fixed in #40783

[mayanala-coxauto]

It seems like if I have more than 8 Dashboard filters then it goes back to re-running the queries switching tabs.

[kulyk]

@mayanala-coxauto, after some investigation, I think the issue is related to pivot tables, and dashboard filters are not involved AFAICT. The pivot table issue is now tracked at #41043

[mayanala-coxauto]

@kulyk I'm not certain if it's just with pivot tables. I'm able to reproduce the issue with Sample DB.

Steps to Reproduce:

1. Create Native Sql question with field filters and normal table visualization which default. Make created_at field as required field.
   SELECT
   "PUBLIC"."PEOPLE"."ID" AS "ID",
   "PUBLIC"."PEOPLE"."ADDRESS" AS "ADDRESS",
   "PUBLIC"."PEOPLE"."EMAIL" AS "EMAIL",
   "PUBLIC"."PEOPLE"."PASSWORD" AS "PASSWORD",
   "PUBLIC"."PEOPLE"."NAME" AS "NAME",
   "PUBLIC"."PEOPLE"."CITY" AS "CITY",
   "PUBLIC"."PEOPLE"."LONGITUDE" AS "LONGITUDE",
   "PUBLIC"."PEOPLE"."STATE" AS "STATE",
   "PUBLIC"."PEOPLE"."SOURCE" AS "SOURCE",
   "PUBLIC"."PEOPLE"."BIRTH_DATE" AS "BIRTH_DATE",
   "PUBLIC"."PEOPLE"."ZIP" AS "ZIP",
   "PUBLIC"."PEOPLE"."LATITUDE" AS "LATITUDE",
   "PUBLIC"."PEOPLE"."CREATED_AT" AS "CREATED_AT"
   FROM
   "PUBLIC"."PEOPLE"
   where true
   [[and {{v_id}}]]
   [[ and {{v_name}}]]
   [[ and {{v_city}}]]
   [[ and {{v_state}}]]
   [[ and {{v_source}}]]
   [[ and {{v_zip}}]]
   [[ and {{v_email}}]]
   [[ and {{v_password}}]]
   [[ and {{v_created_at}}]]
   LIMIT
   1048575

Native Sql Question with 9 filters looks as follows

2. Create a Dashboard with 8 filters(in my case, I left the password field) and 2 tabs for same question created from step 1.

3. Switch between tabs and notice messages from /var/log/messages. Since queries complete so fast, I had to look at /var/log/messages. In our environment, we check on Athena recent queries. Notice that re-run doesn’t happen.

4. Add 9th filter, and repeat 3). Notice that re-run of the queries happen.

[mayanala-coxauto]

Question

Dashboard

[kulyk]

Thank you for sharing such thorough repro steps, @mayanala-coxauto 🙏 I'll investigate

[JesseSDevaney]

The fix for more than 8 filters causing queries to be re-run has been merged here and will be added in 49.8:

• 🤖 backported "Fix queries being re-run because of broken parameters comparison" #41739

[ignacio-mb]

Just as a comment, queries are still being rerun when switching between tabs if the tab has a Pivot table

[mayanala-coxauto]

But we do not have any pivot tables in our Dashboards. Just tables and map visualizations.

[ignacio-mb]

Hi @mayanala-coxauto, for that I've opened a feature request here: #42956