Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Filters button cropped when a lot of values #40071

Closed
mngr opened this issue Mar 13, 2024 · 0 comments · Fixed by #40075
Closed

Apply Filters button cropped when a lot of values #40071

mngr opened this issue Mar 13, 2024 · 0 comments · Fixed by #40075
Assignees
Milestone

Comments

@mngr
Copy link

mngr commented Mar 13, 2024

Describe the bug

When there are a lot of values in the filter, the Apply Filters button is not visible until you scroll the whole lost and then scroll the second scroller to see it. This happens because form element is cropped by enclosing div.
Captura de ecrã 2024-03-13, às 13 09 47

To Reproduce

  1. Start new question
  2. Choose Sample Database -> Accounts
  3. Click on Filter button
  4. Choose Country
  5. You'll see a modal with filter values with 2 vertical scrollers, the second one will be scrolled to show the inactive Add Filter button, but the header will be cropped
Captura de ecrã 2024-03-13, às 13 14 30 6. Select any value and click on Add Filter, the modal will be closed 7. Click on the added filter button 8. You'll see a modal without Update Filter button visible, you have to scroll the whole list of values and scroll again to see it Captura de ecrã 2024-03-13, às 13 22 57

Expected behavior

The form with should not be cropped and put in the scroller at all, it should be visible full with the header and the button (Add Filter or Update Filter)

Logs

No response

Information about your Metabase installation

master

Severity

Might be blocking people from adding / editing filters

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants