Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling with filter field values #40075

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented Mar 13, 2024

Fixes #40071

The fix is not ideal but it should fix the issue in real world cases.

Ideally I wanted to make the value dynamic but I cannot make it work with Popover.

How to verify:

  • New -> Question -> Orders
  • Try adding a filter on Orders.Quantity and Product.Category on different screen sizes:
Screenshot 2024-03-13 at 15 50 26 Screenshot 2024-03-13 at 15 50 35 Screenshot 2024-03-13 at 15 50 55

@ranquild ranquild self-assigned this Mar 13, 2024
@ranquild ranquild requested a review from a team March 13, 2024 13:52
@ranquild ranquild added the backport Automatically create PR on current release branch on merge label Mar 13, 2024
@ranquild ranquild removed the request for review from a team March 13, 2024 14:01
@ranquild ranquild marked this pull request as draft March 13, 2024 14:01
@ranquild ranquild requested a review from a team March 13, 2024 14:05
@ranquild ranquild marked this pull request as ready for review March 13, 2024 14:05
Copy link

replay-io bot commented Mar 13, 2024

Status Complete ↗︎
Commit efc4214
Results
⚠️ 2 Flaky
2359 Passed

@ranquild ranquild requested a review from mngr March 13, 2024 15:15
@ranquild ranquild merged commit 9e445bd into master Mar 13, 2024
108 checks passed
@ranquild ranquild deleted the filter-value-picker-scroll branch March 13, 2024 15:20
Copy link

@ranquild Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

github-actions bot pushed a commit that referenced this pull request Mar 13, 2024
metabase-bot bot added a commit that referenced this pull request Mar 13, 2024
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .Team/QueryingComponents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply Filters button cropped when a lot of values
2 participants