You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Model indexes should surface records from models in search. When new values are present they should be indexed, and when values are no longer present they should no longer be in the index.
There's an issue when removing values from the index where we use the wrong column name in the update:
(when (seq deletions)
(t2/delete! ModelIndexValue
:model_index_id (:id model-index)
:pk_ref [:in (->> deletions (map first))])) ;; -> pk_ref is the column in model_index, not model_index_value
This yields values like:
select pk_ref, value_ref, state, error from model_index where state ='error'
pk_ref,value_ref,state,error
"[""field"",563028,null]","[""field"",563018,null]",error,"ERROR: column ""pk_ref"" does not exist Position: 68""[""field"",534030,null]","[""field"",534037,null]",error,"ERROR: column ""pk_ref"" does not exist Position: 68""[""field"",545945,null]","[""field"",545948,null]",error,"ERROR: column ""pk_ref"" does not exist Position: 68"
To Reproduce
Index a model, have it not have values any longer, and then it errors trying to remove them.
Expected behavior
No response
Logs
No response
Information about your Metabase installation
master
Severity
p2 (possibly higher but fixing now)
Additional context
No response
The text was updated successfully, but these errors were encountered:
Describe the bug
Model indexes should surface records from models in search. When new values are present they should be indexed, and when values are no longer present they should no longer be in the index.
There's an issue when removing values from the index where we use the wrong column name in the update:
This yields values like:
To Reproduce
Index a model, have it not have values any longer, and then it errors trying to remove them.
Expected behavior
No response
Logs
No response
Information about your Metabase installation
master
Severity
p2 (possibly higher but fixing now)
Additional context
No response
The text was updated successfully, but these errors were encountered: