Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced option to turn off syncing field values doesn't work #40715

Closed
qnkhuat opened this issue Mar 28, 2024 · 2 comments · Fixed by #41170 or #41348
Closed

Advanced option to turn off syncing field values doesn't work #40715

qnkhuat opened this issue Mar 28, 2024 · 2 comments · Fixed by #41170 or #41348
Assignees
Labels
Administration/Metadata & Sync Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Team/BackendComponents also known as BEC Type:Bug Product defects
Milestone

Comments

@qnkhuat
Copy link
Contributor

qnkhuat commented Mar 28, 2024

Describe the bug

In the database setting you have an 3 advanced options to control field values syncing. When you select “Only when adding a new filter widget” or “Never, I’ll do this manually if I need to”, the existing field values sync job should be removed. Right now the jobs are still there and sync will continue to happens

To Reproduce

  1. Go to Admin -> Database setting
  2. Go down to "Scanning field values" and select "Never, I'll do this manually if I need to"
  3. Make this query: select * from qrtz_triggers where trigger_name = 'metabase.task.update-field-values.trigger.<YOUR-DB-ID>';. This should return nothing

Expected behavior

There is no scheduled triggers for syncing field values

Logs

No response

Information about your Metabase installation

master, and probably has been like this since forever

Severity

unexpected behavior

Additional context

No response

@qnkhuat
Copy link
Contributor Author

qnkhuat commented Mar 28, 2024

Once we fix this, we need to ensure the existing triggers for databases that have enabled these options are also removed.

@luizarakaki luizarakaki added the Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness label Mar 28, 2024
@qnkhuat qnkhuat self-assigned this Apr 8, 2024
@qnkhuat
Copy link
Contributor Author

qnkhuat commented Apr 8, 2024

State matrix mapping to its corresponding option name on FE.

Use cases let user control scheduling is_full_sync is_on_demand cache_field_values metadata_sync_schedule cache_field_values_schedule sync_strategy
Default false true false nil randomized randomized auto_full_sync
Regularly on a schedule true true false non-nil map user input user input manual_full_sync
Only when adding a new filter true false true nil user input nil manual_on_demand
Never, I'll do it manually true false false nil user input nil manual_metadata_only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration/Metadata & Sync Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Team/BackendComponents also known as BEC Type:Bug Product defects
Projects
None yet
2 participants