Migration to remove scan field values triggers for DBs that turn it off #41348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scan field values
|
crisptrutski
approved these changes
Apr 12, 2024
Comment on lines
1083
to
1084
| (qs/delete-trigger scheduler (triggers/key (format "metabase.task.update-field-values.trigger.%d" (:id db))))) | ||
| (t2/update! :model/Database :id [:in (map :id dbs-without-scan-field-values)] {:cache_field_values_schedule nil}) |
There was a problem hiding this comment.
It looks like we only ever use the ids from the database, so we might as well not select any other fields, and immediately map to just these values.
There was a problem hiding this comment.
we also need details, is_full_sync, is_on_demand for the filter.
|
This seems to have broken |
Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>
…eld-values-triggers
yea it was a flake, which I fixed in an upstream commit |
|
@qnkhuat Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
qnkhuat
added a commit
that referenced
this pull request
Apr 16, 2024
qnkhuat
added a commit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part to fix #40715
This adds a migration that will scan field values trigger for existing DBs that have advanced scan options are either "Only when adding a new filter" or "Never, I'll do this manually if I need to".