Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questions and Models (integrate QuestionPicker component) #40719

Closed
5 tasks done
Tracked by #40717
kamilmielnik opened this issue Mar 28, 2024 · 1 comment
Closed
5 tasks done
Tracked by #40717

Questions and Models (integrate QuestionPicker component) #40719

kamilmielnik opened this issue Mar 28, 2024 · 1 comment
Assignees
@kamilmielnik
Labels
.Frontend .Team/QueryingComponents

Comments

@kamilmielnik
Copy link
Contributor

kamilmielnik commented Mar 28, 2024 •
edited
Loading

Depends on #40207

  • do not show questions tab if there are no questions?
  • do not show models tab if there are no models?
  • handle collectionId prop
  • determine which tab to open initially (when editing, i.e. starting with initial value)
  • search for model + click
@kamilmielnik kamilmielnik mentioned this issue Mar 28, 2024
Closed
@kamilmielnik kamilmielnik changed the title Integrate QuestionPicker (depends on https://github.com/metabase/metabase/pull/40207) Questions and Models (integrate QuestionPicker component) Mar 28, 2024
@kamilmielnik kamilmielnik mentioned this issue Apr 3, 2024
Merged
@kamilmielnik kamilmielnik self-assigned this May 6, 2024
@kamilmielnik kamilmielnik mentioned this issue May 6, 2024
Merged
@kamilmielnik
Copy link
Contributor Author

Closed by #42268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilmielnik kamilmielnik

Labels
.Frontend .Team/QueryingComponents
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kamilmielnik