Question + Model Picker #40207
Merged
Question + Model Picker #40207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
iethree
force-pushed
the
entity-picker/question-picker
branch
from
495bccf
to
e6c5112
Compare
iethree
force-pushed
the
entity-picker/question-picker
branch
from
e6c5112
to
c1d45e8
Compare
Merged
iethree
force-pushed
the
entity-picker/question-picker
branch
from
c1d45e8
to
7634725
Compare
iethree
commented
Mar 26, 2024
frontend/src/metabase/models/containers/ModelDetailPage/ModelDetailPage.tsx
Outdated
Show resolved
Hide resolved
This was referenced Mar 28, 2024
Closed
iethree
force-pushed
the
entity-picker/question-picker
branch
2 times, most recently
from
d565856
to
c45a1af
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 152ca0e...f8e2612.
|
iethree
force-pushed
the
entity-picker/question-picker
branch
from
c45a1af
to
66ca287
Compare
iethree
force-pushed
the
entity-picker/question-picker
branch
from
97a8d66
to
a6edf49
Compare
rafpaf
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
This looks gorgeous.
I wrote up some feedback on the interface here: https://www.notion.so/metabase/Question-Model-picker-UI-feedback-28191f6f34cd42d89ba9cd5d28af20fe?pvs=4
For me the only major blocker is the selectedItem issue mentioned below. I'm optimistically approving this PR
...end/src/metabase-enterprise/sandboxes/components/EditSandboxingModal/EditSandboxingModal.tsx
Show resolved
Hide resolved
frontend/src/metabase/common/components/EntityPicker/components/EntityPickerModal/TabsView.tsx
Outdated
Show resolved
Hide resolved
frontend/src/metabase/common/components/EntityPicker/components/EntityPickerModal/TabsView.tsx
Outdated
Show resolved
Hide resolved
frontend/src/metabase/common/components/QuestionPicker/components/QuestionPicker.tsx
Show resolved
Hide resolved
frontend/src/metabase/common/components/QuestionPicker/components/QuestionPicker.tsx
Outdated
Show resolved
Hide resolved
frontend/src/metabase/common/components/QuestionPicker/components/QuestionPicker.tsx
Outdated
Show resolved
Hide resolved
frontend/src/metabase/common/components/QuestionPicker/components/QuestionPicker.tsx
Outdated
Show resolved
Hide resolved
frontend/src/metabase/models/containers/FormModelPicker/FormModelPicker.tsx
Show resolved
Hide resolved
frontend/src/metabase/models/containers/ModelDetailPage/ModelDetailPage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/metabase/parameters/components/ValuesSourceModal/ValuesSourceCardModal.tsx
Show resolved
Hide resolved
iethree
force-pushed
the
entity-picker/question-picker
branch
from
84c2993
to
e04b0b1
Compare
iethree
force-pushed
the
entity-picker/question-picker
branch
from
0df5169
to
41da831
Compare
iethree
force-pushed
the
entity-picker/question-picker
branch
from
41da831
to
eb99852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36376
Description
Adds a question/model picker using the entity picker.
Used by
Checklist