Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API error not handled in the query step preview #40724

Closed
kamilmielnik opened this issue Mar 28, 2024 · 1 comment · Fixed by #40996
Closed

API error not handled in the query step preview #40724

kamilmielnik opened this issue Mar 28, 2024 · 1 comment · Fixed by #40996
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/GUI Query builder catch-all, including simple mode .Team/QueryingComponents Type:Bug Product defects

Comments

@kamilmielnik
Copy link
Contributor

kamilmielnik commented Mar 28, 2024 •
edited

Describe the bug

2024-03-28.19-29-49.mp4

To Reproduce

  1. Start a new GUI question
  2. Select source table
  3. Disable network
  4. Click "preview" button

There's an API error and preview will stay in a loading state indefinitely.

Expected behavior

API errors should be shown. Loading state should not be displayed

Information about your Metabase installation

master, bee426d

Severity

P3
@kamilmielnik kamilmielnik added Type:Bug Product defects .Needs Triage .Frontend Querying/GUI Query builder catch-all, including simple mode .Team/QueryingComponents Priority:P2 Average run of the mill bug Priority:P3 Cosmetic bugs, minor bugs with a clear workaround and removed .Needs Triage Priority:P2 Average run of the mill bug labels Mar 28, 2024
@kamilmielnik
Copy link
Contributor Author

Partially duplicate of #40608.
#40609 fixes #40608, so I'll rename this issue to be about error not being handled only.

@kamilmielnik kamilmielnik changed the title Preview available for empty question API error not handled in the preview Apr 3, 2024
@kamilmielnik kamilmielnik changed the title API error not handled in the preview API error not handled in the query step preview Apr 3, 2024
romeovs added a commit that referenced this issue Apr 3, 2024
@romeovs
Add reproduction for #40724
bbb4163
@romeovs romeovs mentioned this issue Apr 3, 2024
Merged
romeovs added a commit that referenced this issue Apr 5, 2024
@romeovs @kamilmielnik
No error message on preview api error (#40996)
a91f3d8 
* Correctly pass an error string to Vizualization

* Fix error layout for preview vizualization

* Do not animate preview vizualization height

* Add reproduction for #40724

* Fix test description

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

* Rename coerceError to getErrorMessage

---------

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/GUI Query builder catch-all, including simple mode .Team/QueryingComponents Type:Bug Product defects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No error message on preview api error metabase/metabase
1 participant
@kamilmielnik