Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting Hide this card if there are no results at Dashboard level will remove it from the subscription even if there are results #40726

Closed
Tony-metabase opened this issue Mar 28, 2024 · 0 comments · Fixed by #40743
Closed

Setting Hide this card if there are no results at Dashboard level will remove it from the subscription even if there are results #40726

Tony-metabase opened this issue Mar 28, 2024 · 0 comments · Fixed by #40743
Assignees
@adam-james-v
Labels
.Escalation Priority:P2 Average run of the mill bug Reporting/Pulses Now called Subscriptions Type:Bug Product defects
Milestone
0.49.3

Comments

@Tony-metabase
Copy link
Contributor

Tony-metabase commented Mar 28, 2024 •
edited
Loading

Describe the bug

Setting Hide this card if there are no results at Dashboard level will remove it from the subscription even if there are results

To Reproduce

  1. Go to New -> Question -> Sample Database -> Orders -> Save
  2. Add it to dashboard and set the question to Hide this card if there are no results
image
  1. Send a Test subscription to email > I just get an empty email
image

There are results in the question:

image

Expected behavior

Subscription needs to work as expected since there are results

Logs

None that are relevant

Information about your Metabase installation

1.49.1 and master

Severity

This is blocking since subscription needs to work. This will break functionality for most customers I think and they won't know what is wrong

Additional context

No response
@Tony-metabase Tony-metabase added Type:Bug Product defects Priority:P2 Average run of the mill bug Reporting/Pulses Now called Subscriptions .Needs Triage labels Mar 28, 2024
@adam-james-v adam-james-v self-assigned this Mar 28, 2024
adam-james-v added a commit that referenced this issue Mar 28, 2024
@adam-james-v
Cards with Results Should Show up in Subscriptions
01e710b 
Fixes: #40726

This PR fixes a bug where setting 'Hide thie card if there are no results' in a Dashcard's viz-settings would hide the
card even when there were results.
@adam-james-v adam-james-v mentioned this issue Mar 28, 2024
Merged
adam-james-v added a commit that referenced this issue Mar 28, 2024
@adam-james-v
Cards with Results Should Show up in Subscriptions (#40743)
23bda11 
* Cards with Results Should Show up in Subscriptions

Fixes: #40726

This PR fixes a bug where setting 'Hide thie card if there are no results' in a Dashcard's viz-settings would hide the
card even when there were results.

* adjust test to show that the setting is respected

Before, the setting would always hide the card. Now, the card is only hidden when there are no results. This test sets
up 4 cards: 2 are normal, 2 have no results, but 1 has the setting to hide empty. THerefore, we should expect to see 3 results.
adam-james-v added a commit that referenced this issue Mar 28, 2024
@adam-james-v
Cards with Results Should Show up in Subscriptions (#40743)
28b1d44 
* Cards with Results Should Show up in Subscriptions

Fixes: #40726

This PR fixes a bug where setting 'Hide thie card if there are no results' in a Dashcard's viz-settings would hide the
card even when there were results.

* adjust test to show that the setting is respected

Before, the setting would always hide the card. Now, the card is only hidden when there are no results. This test sets
up 4 cards: 2 are normal, 2 have no results, but 1 has the setting to hide empty. THerefore, we should expect to see 3 results.
@adam-james-v adam-james-v added this to the 0.49.3 milestone Mar 28, 2024
adam-james-v added a commit that referenced this issue Mar 29, 2024
@metabase-bot @adam-james-v
🤖 backported "Cards with Results Should Show up in Subscriptions" (#4…
d6c4bad 
…0762)

* Cards with Results Should Show up in Subscriptions (#40743)

* Cards with Results Should Show up in Subscriptions

Fixes: #40726

This PR fixes a bug where setting 'Hide thie card if there are no results' in a Dashcard's viz-settings would hide the
card even when there were results.

* adjust test to show that the setting is respected

Before, the setting would always hide the card. Now, the card is only hidden when there are no results. This test sets
up 4 cards: 2 are normal, 2 have no results, but 1 has the setting to hide empty. THerefore, we should expect to see 3 results.

* test is fine?

---------

Co-authored-by: Adam James <adam.vermeer2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adam-james-v adam-james-v

Labels
.Escalation Priority:P2 Average run of the mill bug Reporting/Pulses Now called Subscriptions Type:Bug Product defects
Projects
None yet
Milestone
0.49.3
Development

Successfully merging a pull request may close this issue.

Cards with Results Should Show up in Subscriptions metabase/metabase
3 participants
@paoliniluis @adam-james-v @Tony-metabase