Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure SQL Server caches the connection which leads to reusable old sessions #41025

Open
paoliniluis opened this issue Apr 4, 2024 · 1 comment
Labels
Database/SQLServer Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Processor .Team/QueryProcessor :hammer_and_wrench: Type:Bug Product defects

Comments

@paoliniluis
Copy link
Contributor

paoliniluis commented Apr 4, 2024

Describe the bug

A customer reported that they changed the password in their SQL server and that Metabase can still connect with the old password and not accepting the new one, so I had to see it with my own eyes

To Reproduce

  1. create a SQL server on Azure (logical, it's sort of the PaaS SQL server that Azure has)\
  2. connect Metabase to it
  3. change password of the database
  4. see that Metabase keeps working with the old password...

SQL Server in the cloud seems to be using some sort of caching on the handshakes and not checking the password, so old sessions can be reused

Expected behavior

We should be able to connect with the new password

Logs

NA

Information about your Metabase installation

v49.x

Severity

P3

Additional context

This is mostly sure a Microsoft security bug, they can't sacrifice security for performance

NOTE: I tested with a different SQL client and it's the same thing

@paoliniluis paoliniluis added Type:Bug Product defects Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Database/SQLServer labels Apr 4, 2024
@paoliniluis
Copy link
Contributor Author

Microsoft is aware of the situation microsoft/mssql-jdbc#2334

paoliniluis added a commit that referenced this issue May 3, 2024
paoliniluis added a commit that referenced this issue May 3, 2024
paoliniluis added a commit that referenced this issue May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Database/SQLServer Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Processor .Team/QueryProcessor :hammer_and_wrench: Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants