Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archived models continue to be cached #41318

Closed
sambradbury opened this issue Apr 11, 2024 · 0 comments · Fixed by #41329
Closed

Archived models continue to be cached #41318

sambradbury opened this issue Apr 11, 2024 · 0 comments · Fixed by #41329
Assignees
@johnswanson
Labels
Type:Bug Product defects
Milestone
0.49.7

Comments

@sambradbury
Copy link

Describe the bug

Models that have been archive continue to show up in the cache log.

To Reproduce

  1. Archive a model
  2. Wait for caching schedule to trigger.
  3. Go to Admin settings > Tools > Model Caching Log
  4. See that the archived model is still being cached on the set schedule

Expected behavior

I would not expect archived models to be cached.

Logs

No response

Information about your Metabase installation

- Metabase version: v1.49.2

Severity

Low

Additional context

No response
@johnswanson johnswanson self-assigned this Apr 11, 2024
johnswanson added a commit that referenced this issue Apr 11, 2024
@johnswanson
Don't say we'll cache archived models
d1c1409 
When we actually run the job to cache models, we select "refreshable
models", which selects `PersistedInfo` where:

- the `state` is something refreshable, and

- the question marked for caching is actually a model, and

- the question hasn't been archived.

However, when we selected `PersistedInfo`s to display to the user, we
didn't apply any conditions. Instead, we included PersistedInfo where
the question was not a model, or where the question had been archived.

To prevent confusion, let's hide these.

Fixes #41318
@johnswanson johnswanson mentioned this issue Apr 11, 2024
Merged
johnswanson added a commit that referenced this issue Apr 18, 2024
@johnswanson
Don't say we'll cache archived models (#41329)
3706710 
When we actually run the job to cache models, we select "refreshable
models", which selects `PersistedInfo` where:

- the `state` is something refreshable, and

- the question marked for caching is actually a model, and

- the question hasn't been archived.

However, when we selected `PersistedInfo`s to display to the user, we
didn't apply any conditions. Instead, we included PersistedInfo where
the question was not a model, or where the question had been archived.

To prevent confusion, let's hide these.

Fixes #41318
github-actions bot pushed a commit that referenced this issue Apr 18, 2024
@johnswanson
Don't say we'll cache archived models (#41329)
ba99f54 
When we actually run the job to cache models, we select "refreshable
models", which selects `PersistedInfo` where:

- the `state` is something refreshable, and

- the question marked for caching is actually a model, and

- the question hasn't been archived.

However, when we selected `PersistedInfo`s to display to the user, we
didn't apply any conditions. Instead, we included PersistedInfo where
the question was not a model, or where the question had been archived.

To prevent confusion, let's hide these.

Fixes #41318
metabase-bot bot added a commit that referenced this issue Apr 18, 2024
@metabase-bot @johnswanson
Don't say we'll cache archived models (#41329) (#41613)
a46f3e0 
When we actually run the job to cache models, we select "refreshable
models", which selects `PersistedInfo` where:

- the `state` is something refreshable, and

- the question marked for caching is actually a model, and

- the question hasn't been archived.

However, when we selected `PersistedInfo`s to display to the user, we
didn't apply any conditions. Instead, we included PersistedInfo where
the question was not a model, or where the question had been archived.

To prevent confusion, let's hide these.

Fixes #41318

Co-authored-by: John Swanson <john.swanson@metabase.com>
@bshepherdson bshepherdson added this to the 0.49.7 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnswanson johnswanson

Labels
Type:Bug Product defects
Projects
None yet
Milestone
0.49.7
Development

Successfully merging a pull request may close this issue.

Don't say we'll cache archived models metabase/metabase
4 participants
@bshepherdson @johnswanson @sambradbury @ignacio-mb