Borders not respecting bordered=false parameter for static embedding

[air-rick]

Describe the bug

After the upgrade to Version 49, all of our embedded dashboards are showing with borders. We are using the following embed settings:

theme=transparent&bordered=false&titled=false

This seems to be a bug in Version 49 that was not present in version 48.

To Reproduce

1. Create a dashboard
2. Enable static embed
3. Choose theme as transparent
4. Choose bordered as false
5. Choose titled as false
6. Embed in website
7. Refresh page, and dashboard will show up with borders

Expected behavior

There should not be any borders showing

Logs

No response

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.22+7",
    "java.vendor": "Eclipse Adoptium",
    "java.vendor.url": "https://adoptium.net/",
    "java.version": "11.0.22",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.22+7",
    "os.name": "Linux",
    "os.version": "5.10.213-201.855.amzn2.x86_64",
    "user.language": "en",
    "user.timezone": "GMT"
  },
  "metabase-info": {
    "databases": [
      "snowflake",
      "postgres"
    ],
    "hosting-env": "unknown",
    "application-database": "postgres",
    "application-database-details": {
      "database": {
        "name": "PostgreSQL",
        "version": "14.10"
      },
      "jdbc-driver": {
        "name": "PostgreSQL JDBC Driver",
        "version": "42.7.2"
      }
    },
    "run-mode": "prod",
    "version": {
      "date": "2024-04-11",
      "tag": "v1.49.5",
      "hash": "31c4887"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity

Very annoying, affecting our branding in our product.

Additional context

No response

[npretto]

@air-rick is the border only showing up on the top side?

[air-rick]

No, it is showing up around each individual card

…

On Mon, Apr 15, 2024, 4:45 PM Nicolò Pretto ***@***.***> wrote: @air-rick <https://github.com/air-rick> is the border only showing up on the top side? — Reply to this email directly, view it on GitHub <#41393 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT55X5T7Z4Y67VYSCGTJ4PDY5OHSLAVCNFSM6AAAAABGGNLR5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWGIZTOMJZGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>