Tab query param not applied in embed

[tboulis]

Describe the bug

Hello everyone 👋
We've noticed that in the latest version (v0.49.5) the URL?tab=tab_id is not applied when embedding a dashboard in an iframe.
In our case we have https://URL?tab=2-tab-2 but the iframe renders the tab with id 1-tab-1

Screenshot:

To Reproduce

1. Create a dashboard with more than one tabs
2. Enable embedding for that dashboard
3. Create an embedding URL and defined a tab other than the first in the url of the embedded dashboard by appending ?tab="TAB_ID" in the url
4. Expect the embed to open the tab with id "TAB_ID:
5. The embed loads the default tab (first one)

Expected behavior

It should render the url defined tab like it did in previous versions

Logs

No response

Information about your Metabase installation

- Browser: Google Chrome Version 123.0.6312.123 (Official Build) (arm64)
- OS: Macos 14.4.1 Sonoma
- DB: PostgreSQL
- Metabase instance: self-hosted but happens on the cloud instance too
- Metabase version: `v0.49.5`

Severity

High - blocks multiple users

Additional context

No response

[saadbahir]

I am encountering the same problem

Seems like there are a lot of issues in v49

[saadbahir]

Hello @kulyk

Sorry to ping you like this but I wondered whether your PR right here may have introduced this regression

[saadbahir]

@deniskaber thank you for triaging this ticket!

If you have any suggestion that we can use to "force" the tab selection when we open the embed (using some sdk or post message), I would welcome it very much!

[npretto]

This has been fixed by #41399, a release should be made soon

[npretto]

To add some context, I think this is what's going on:
#41399 doesn't render <DashboardTabs> unless we have tabs, <DashboardTabs calls useDashboardTabs which dispatches initTabs before we have the tabs loaded, causing the code to think we're selecting an invalid tab on the reducer and therefore setting the selected tab to null

metabase/frontend/src/metabase/dashboard/actions/tabs.ts

Lines 569 to 578 in 5a7360d

	builder.addCase(initTabs, (state, { payload: { slug } }) => {
	const { prevTabs } = getPrevDashAndTabs({ state });
	const idFromSlug = getIdFromSlug(slug);
	const tabId =
	idFromSlug && prevTabs.map(t => t.id).includes(idFromSlug)
	? idFromSlug
	: prevTabs[0]?.id ?? null;
	state.selectedTabId = tabId;

[saadbahir]

Thank you @npretto for your quick feedback!

This is a vital fix for us as we use Metabase Embedding at scale and this is currently breaking a lot of our workflows

Do you please have any timeline on the release? are we talking hours or days?
Thank you for your help!

[Tony-metabase]

@saadbahir we should be releasing 49.6 today so expect a couple of more hours for it to be available