Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Epic] Let time granularity be parameterized for MBQL questions #42118

Open
2 of 6 tasks
bshepherdson opened this issue May 1, 2024 · 0 comments
Open
2 of 6 tasks

[Epic] Let time granularity be parameterized for MBQL questions #42118

bshepherdson opened this issue May 1, 2024 · 0 comments
Assignees
@bshepherdson @ranquild
Labels
.Epic Feature Implementation or Project Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Team/QueryingComponents .Team/QueryProcessor :hammer_and_wrench:

Comments

@bshepherdson
Copy link
Contributor

bshepherdson commented May 1, 2024 •
edited by ranquild

Links

Implementation Plan

Milestone 1: Core functionality

Tasks
Beta Give feedback
  3. Temporal unit parameters in dashboards #43212
    .Team/QueryingComponents no-backport
    ranquild
  4. [Testing Plan] Temporal unit parameters in dashboards #43599
    Querying/Parameters & Variables
    ranquild

Milestone 2: Allowlist of temporal units

Tasks
Beta Give feedback
@bshepherdson bshepherdson added Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Epic Feature Implementation or Project .Team/QueryProcessor :hammer_and_wrench: .Team/QueryingComponents labels May 1, 2024
@bshepherdson bshepherdson added this to the 0.50 milestone May 1, 2024
@bshepherdson bshepherdson mentioned this issue May 1, 2024
Merged
bshepherdson added a commit that referenced this issue May 2, 2024
@bshepherdson
[QP] Support :temporal-unit parameters on MBQL queries (#42116)
4fa5778 
This is a new parameter `:type` (and `:widget-type`) to choose a time
granularity (a `:temporal-unit`, eg. `month`, `day`, `day-of-week`)
which should replace the unit on the target field for the parameter.

The target field should be a breakout with a temporal type (date,
datetime) that's compatible with the input unit. The value of the
parameter should be a string or keyword naming one of the units:
`"month"`, `:month`.

Part of #42118.
bshepherdson added a commit that referenced this issue May 3, 2024
@bshepherdson
Add a few tests for time granularity parameters (#42119)
bf5eb3a 
The API/model schemas for dashboard parameters are general enough
that they just work for this new type, which doesn't look very different
from a value parameter right now.

Part of #42118.
@perivamsi perivamsi removed this from the 0.50 milestone May 13, 2024
@ranquild ranquild mentioned this issue Jun 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bshepherdson bshepherdson

@ranquild ranquild

Labels
.Epic Feature Implementation or Project Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Team/QueryingComponents .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@perivamsi @bshepherdson @ranquild