-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Columns are excluded from the unformatted option when downloading #42500
Labels
.Backend
.Escalation
Priority:P1
Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness
Reporting/Export
Type:Bug
Product defects
Milestone
Comments
Tony-metabase
added
Type:Bug
Product defects
Priority:P1
Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness
Reporting/Export
.Backend
.Escalation
labels
May 10, 2024
Tony-metabase
changed the title
Columns are excluded form the formatted/unformatted option when downloading
Columns are excluded from the unformatted option when downloading
May 10, 2024
adam-james-v
added a commit
that referenced
this issue
May 10, 2024
Fixes: #42500 When format-rows is false, we want to also pass that true/false value to the title column formatting. That is, if a column is renamed and formatting is applied, we want to use that column's name. But, if a column is renamed and the user exports unformatted csv or json, the custom column name should NOT be used, as was the behaviour in prior versions.
adam-james-v
added a commit
that referenced
this issue
May 10, 2024
* Format Rows toggle also applies to Column Names Fixes: #42500 When format-rows is false, we want to also pass that true/false value to the title column formatting. That is, if a column is renamed and formatting is applied, we want to use that column's name. But, if a column is renamed and the user exports unformatted csv or json, the custom column name should NOT be used, as was the behaviour in prior versions. * write a better test explanation
github-actions bot
pushed a commit
that referenced
this issue
May 10, 2024
* Format Rows toggle also applies to Column Names Fixes: #42500 When format-rows is false, we want to also pass that true/false value to the title column formatting. That is, if a column is renamed and formatting is applied, we want to use that column's name. But, if a column is renamed and the user exports unformatted csv or json, the custom column name should NOT be used, as was the behaviour in prior versions. * write a better test explanation
metabase-bot bot
added a commit
that referenced
this issue
May 11, 2024
* Format Rows toggle also applies to Column Names Fixes: #42500 When format-rows is false, we want to also pass that true/false value to the title column formatting. That is, if a column is renamed and formatting is applied, we want to use that column's name. But, if a column is renamed and the user exports unformatted csv or json, the custom column name should NOT be used, as was the behaviour in prior versions. * write a better test explanation Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
uladzimirdev
pushed a commit
that referenced
this issue
May 11, 2024
* Format Rows toggle also applies to Column Names Fixes: #42500 When format-rows is false, we want to also pass that true/false value to the title column formatting. That is, if a column is renamed and formatting is applied, we want to use that column's name. But, if a column is renamed and the user exports unformatted csv or json, the custom column name should NOT be used, as was the behaviour in prior versions. * write a better test explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
.Backend
.Escalation
Priority:P1
Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness
Reporting/Export
Type:Bug
Product defects
Describe the bug
Columns are excluded form the formatted/unformatted option when downloading ... External systems are expecting an unformatted column which used to be downloaded before 48 differently when it does now in 49
To Reproduce
Expected behavior
If you download unformatted results then nothing should keep the formatting. Applies for Question, Dashboards and anywhere else we offer the unformatted option
Logs
Nothing that is relevant
Information about your Metabase installation
Severity
Blocker since external systems are expecting an unformatted column which used to be downloaded before 48 differently when it does now in 49
Additional context
No response
The text was updated successfully, but these errors were encountered: