Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty collections shown in Data Picker #42957

Closed
kamilmielnik opened this issue May 21, 2024 · 2 comments · Fixed by #42959
Closed

Empty collections shown in Data Picker #42957

kamilmielnik opened this issue May 21, 2024 · 2 comments · Fixed by #42959
Assignees
@kamilmielnik
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode .Team/QueryingComponents Type:Bug Product defects
Milestone
0.50

Comments

@kamilmielnik
Copy link
Contributor

kamilmielnik commented May 21, 2024 •
edited
Loading

Describe the bug

Slack thread

To Reproduce

  1. Create a model
  2. Create a collection and add a question to it (but not the model from step 1)
  3. Start a new question
  4. Open Models tab

Collection created in step 2 should not be visible

Information about your Metabase installation

master, c09ec3d

Severity

P2
@kamilmielnik kamilmielnik added Type:Bug Product defects .Needs Triage .Frontend .Team/QueryingComponents Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode and removed .Needs Triage labels May 21, 2024
@kamilmielnik kamilmielnik self-assigned this May 21, 2024
kamilmielnik added a commit that referenced this issue May 21, 2024
@kamilmielnik
Add repro for #42957
6043eb6
@kamilmielnik kamilmielnik mentioned this issue May 21, 2024
Merged
@kamilmielnik kamilmielnik added this to the 0.50 milestone May 21, 2024
@iethree
Copy link
Contributor

iethree commented May 21, 2024

@kamilmielnik , I see you added the v50 milestone. I thought metrics weren't in 50?

@kamilmielnik
Copy link
Contributor Author

@iethree The issue is not metrics-specific, repro steps just happened to be. I changed it to models so it's clear.

kamilmielnik added a commit that referenced this issue May 23, 2024
@kamilmielnik
Fix - Empty collections shown in Data Picker (#42959)
41f6d17 
* Generate different shouldShowItem for different pickers

* Add repro for #42957

* Update test to use models instead of metrics
kamilmielnik added a commit that referenced this issue May 23, 2024
@kamilmielnik
Fix - Empty collections shown in Data Picker (#42959)
3a97c29 
* Generate different shouldShowItem for different pickers

* Add repro for #42957

* Update test to use models instead of metrics
kamilmielnik added a commit that referenced this issue May 23, 2024
@metabase-bot @kamilmielnik
Fix - Empty collections shown in Data Picker (#42959) (#43052)
242fc9f 
* Generate different shouldShowItem for different pickers

* Add repro for #42957

* Update test to use models instead of metrics

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilmielnik kamilmielnik

Labels
.Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode .Team/QueryingComponents Type:Bug Product defects
Projects
None yet
Milestone
0.50
Development

Successfully merging a pull request may close this issue.

Fix - Empty collections shown in Data Picker metabase/metabase
2 participants
@kamilmielnik @iethree