Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot drill to a question via title when dashboard has a filter with multiple values applied #42999

Closed
kamilmielnik opened this issue May 22, 2024 · 2 comments
Closed

Cannot drill to a question via title when dashboard has a filter with multiple values applied #42999

kamilmielnik opened this issue May 22, 2024 · 2 comments
Assignees
@bshepherdson
Labels
.Backend .Duplicate Priority:P2 Average run of the mill bug Querying/Drill Thrus Refining existing queries with Drill Thrus Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards .Team/QueryProcessor :hammer_and_wrench: Type:Bug Product defects

Comments

@kamilmielnik
Copy link
Contributor

kamilmielnik commented May 22, 2024 •
edited

Describe the bug

core.cljs:328 Uncaught (in promise) Error: No protocol method IAssociative.-assoc defined for type number: 16
    at Object.cljs$core$missing_protocol [as missing_protocol] (core.cljs:328:1)
    at cljs$core$IAssociative$_assoc$dyn_117294 (core.cljs:644:1)
    at Object.cljs$core$_assoc [as _assoc] (core.cljs:644:1)
    at Function.cljs$core$IFn$_invoke$arity$3 (core.cljs:2042:1)
    at common.cljc:137:1
    at core.cljc:183:1
    at core.cljc:1630:1
    at core.cljc:195:1
    at malli$core$_update (core.cljc:195:1)
    at core.cljs:7117:1

To Reproduce

e2e repro: #43000

  1. Create a question based on Orders table with limit 5
  2. Add the question to a dashboard
  3. Add "Text or Category" > "Contains" filter
    • can be reproduced with "Contains", "Does not contain", "Starts with" and "Ends with" filters
  4. Enable multiple values on it (important)
  5. Connect the filter to "User" > "Source" column
  6. Set filter value to oo and aa (image)
  7. Apply the filter
  8. Click title of the dashcard

You should be navigated to an ad-hoc question in the query builder, but there's an error in JS console instead, nothing happens in UI.

Information about your Metabase installation

master, 9dbfae2

Severity

P2
@kamilmielnik kamilmielnik added Type:Bug Product defects .Needs Triage .Backend .Team/QueryProcessor :hammer_and_wrench: Priority:P2 Average run of the mill bug Reporting/Dashboards Querying/Parameters & Variables Filter widgets, field filters, variables etc. Querying/Drill Thrus Refining existing queries with Drill Thrus and removed .Needs Triage labels May 22, 2024
kamilmielnik added a commit that referenced this issue May 22, 2024
@kamilmielnik
Add repro for #42999
b0674c0
@kamilmielnik kamilmielnik mentioned this issue May 22, 2024
Merged
@kamilmielnik kamilmielnik changed the title Cannot drill to a question via title when dashboard has a "contains" filter with multiple values applied Cannot drill to a question via title when dashboard has a filter with multiple values applied May 22, 2024
kamilmielnik added a commit that referenced this issue May 22, 2024
@kamilmielnik
Add a workaround for #42999
d7ff869
@kamilmielnik
Copy link
Contributor Author

Please revert this commit when fixing the issue: d7ff869

@kamilmielnik kamilmielnik mentioned this issue May 22, 2024
Merged
kamilmielnik added a commit that referenced this issue May 23, 2024
@kamilmielnik
Add repro for #42999 (#43000)
73e1b12
kamilmielnik added a commit that referenced this issue May 28, 2024
@kamilmielnik
Copy question link from dashboard (#42892)
e7948a7 
* Remove dead CSS

* Use proper types

* Properly type parameterValues

* Add href prop support to LegendCaption

* Extract getNewCardUrl
- move getParametersMappedToDashcard

* Use href in CartesianChart

* Handle RowChart

* Handle Funnel

* Format code

* Fix types

* Update first test in title-drill

* Update test

* Update test

* Update tests
- pass questionId in createQuestionAndDashboard

* Add test for links

* Fix createDashboardWithQuestions

* Add missing click handler

* Fix crash

* Fix typo

* Add a workaround for #42999

* Fix tests

* Fix hover color

* Update comment

* Get rid of mapStateToProps in DashboardGrid

* Invert condition

* Use useCallback instead useMemo

* Do not pass getNewCardUrl down if navigateToNewCardFromDashboard is not present
- Remove default noop for navigateToNewCardFromDashboard in PublicDashboard

* Remove explicit undefined prop
@bshepherdson bshepherdson self-assigned this Jun 5, 2024
@kamilmielnik
Copy link
Contributor Author

Closing as duplicate of #43990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bshepherdson bshepherdson

Labels
.Backend .Duplicate Priority:P2 Average run of the mill bug Querying/Drill Thrus Refining existing queries with Drill Thrus Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards .Team/QueryProcessor :hammer_and_wrench: Type:Bug Product defects
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bshepherdson @kamilmielnik