Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalizer interprets "expression" as a MBQL :expression, but it is just a column name #43089

Closed
luizarakaki opened this issue May 23, 2024 · 0 comments · Fixed by #43336
Closed
Assignees
Labels
.Backend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/MBQL .Team/QueryProcessor :hammer_and_wrench: Type:Bug Product defects
Milestone

Comments

@luizarakaki
Copy link
Contributor

Describe the bug

Customer is getting this exception:

{
  "via": [
    {
      "type": "clojure.lang.ExceptionInfo",
      "message": "Error normalizing query: Error normalizing form: null",
      "data": {
        "query": [
          "expression",
          null,
          "sum",
          "sum_3",
          "sum_2"
        ],
...

When trying to GET /api/cards
with this card

{"table.pivot_column" "created_month",
 "table.cell_column" "sum",
 "card.title" "Funnel view by month",
 "table.column_formatting"
 [{"columns" ["expression" nil "sum" "sum_3" "sum_2"],
...

https://metaboat.slack.com/archives/C04DN5VRQM6/p1716477256872509

To Reproduce

See logs above

Expected behavior

  1. It shouldn't try to normalize columns
  2. The GET request shouldn't completely fail. It should remove the erroring question and warn the user

Logs

No response

Information about your Metabase installation

- Cloud instance, latest v49

Severity

P1

Additional context

https://metaboat.slack.com/archives/C04DN5VRQM6/p1716477256872509

@luizarakaki luizarakaki added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/MBQL .Team/QueryProcessor :hammer_and_wrench: labels May 23, 2024
@dosubot dosubot bot added the .Backend label May 23, 2024
@metamben metamben self-assigned this May 28, 2024
@metamben metamben added this to the 0.49.14 milestone May 30, 2024
metamben added a commit that referenced this issue May 30, 2024
Fixes #43089.

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Backend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/MBQL .Team/QueryProcessor :hammer_and_wrench: Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants