Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize initial dashboard load - load dashboard metadata in parallel with the query #43101

Merged
merged 18 commits into from
May 24, 2024

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented May 24, 2024

Follow up for #42901

Makes query and query_metadata start in parallel, but wait until metadata is loaded because the UI won't work until then.

Screenshot 2024-05-24 at 11 16 37

@ranquild ranquild self-assigned this May 24, 2024
@ranquild ranquild requested review from a team and removed request for a team May 24, 2024 00:09
@ranquild ranquild added the backport Automatically create PR on current release branch on merge label May 24, 2024
@ranquild ranquild changed the title Load dashboard metadata in parallel with the query [WIP] Load dashboard metadata in parallel with the query May 24, 2024
@ranquild ranquild changed the title [WIP] Load dashboard metadata in parallel with the query [WIP] Optimize initial dashboard load - load dashboard metadata in parallel with the query May 24, 2024
@ranquild ranquild requested review from alxnddr and a team May 24, 2024 00:26
@ranquild ranquild changed the title [WIP] Optimize initial dashboard load - load dashboard metadata in parallel with the query Optimize initial dashboard load - load dashboard metadata in parallel with the query May 24, 2024
Copy link

replay-io bot commented May 24, 2024

Status Complete ↗︎
Commit e1e435a
Results
⚠️ 1 Flaky
2567 Passed

@ranquild ranquild removed request for alxnddr and a team May 24, 2024 00:39
@ranquild ranquild changed the title Optimize initial dashboard load - load dashboard metadata in parallel with the query [WIP] Optimize initial dashboard load - load dashboard metadata in parallel with the query May 24, 2024
@ranquild ranquild force-pushed the 41468-parameters-dashboards-mbql-2 branch from b768033 to 17f7166 Compare May 24, 2024 15:12
@ranquild ranquild requested review from uladzimirdev and a team May 24, 2024 15:16
@ranquild ranquild changed the title [WIP] Optimize initial dashboard load - load dashboard metadata in parallel with the query Optimize initial dashboard load - load dashboard metadata in parallel with the query May 24, 2024
…shboards-mbql-2

# Conflicts:
#	frontend/src/metabase/dashboard/components/Dashboard/Dashboard.tsx
Copy link
Contributor

@uladzimirdev uladzimirdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@ranquild ranquild enabled auto-merge (squash) May 24, 2024 19:56
@ranquild ranquild merged commit b18e9ca into master May 24, 2024
110 checks passed
@ranquild ranquild deleted the 41468-parameters-dashboards-mbql-2 branch May 24, 2024 20:38
Copy link

@ranquild Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .Team/QueryingComponents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants