-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize initial dashboard load - load dashboard metadata in parallel with the query #43101
Merged
+127
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranquild
added
the
backport
Automatically create PR on current release branch on merge
label
May 24, 2024
ranquild
changed the title
Load dashboard metadata in parallel with the query
[WIP] Load dashboard metadata in parallel with the query
May 24, 2024
ranquild
changed the title
[WIP] Load dashboard metadata in parallel with the query
[WIP] Optimize initial dashboard load - load dashboard metadata in parallel with the query
May 24, 2024
ranquild
changed the title
[WIP] Optimize initial dashboard load - load dashboard metadata in parallel with the query
Optimize initial dashboard load - load dashboard metadata in parallel with the query
May 24, 2024
|
ranquild
changed the title
Optimize initial dashboard load - load dashboard metadata in parallel with the query
[WIP] Optimize initial dashboard load - load dashboard metadata in parallel with the query
May 24, 2024
ranquild
force-pushed
the
41468-parameters-dashboards-mbql-2
branch
from
May 24, 2024 15:12
b768033
to
17f7166
Compare
ranquild
changed the title
[WIP] Optimize initial dashboard load - load dashboard metadata in parallel with the query
Optimize initial dashboard load - load dashboard metadata in parallel with the query
May 24, 2024
…shboards-mbql-2 # Conflicts: # frontend/src/metabase/dashboard/components/Dashboard/Dashboard.tsx
uladzimirdev
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
@ranquild Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #42901
Makes
query
andquery_metadata
start in parallel, but wait until metadata is loaded because the UI won't work until then.