Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove :metadata/legacy-metric #43131

Closed
Tracked by #42464
snoe opened this issue May 24, 2024 · 0 comments · Fixed by #43134
Closed
Tracked by #42464

Remove :metadata/legacy-metric #43131

snoe opened this issue May 24, 2024 · 0 comments · Fixed by #43134

Comments

@snoe
Copy link
Contributor

snoe commented May 24, 2024

No description provided.

@snoe snoe mentioned this issue May 24, 2024
Open
snoe added a commit that referenced this issue May 24, 2024
@snoe
[Metrics V2] Remove legacy-metric metadata
4064d48 
Fixes #43131
@snoe snoe mentioned this issue May 24, 2024
Merged
snoe added a commit that referenced this issue May 27, 2024
@snoe @metamben
[Metrics V2] Remove legacy-metric metadata (#43134)
a306b35 
* [Metrics V2] Remove legacy-metric metadata

Fixes #43131

* Don't mock metric

* Drop definition_description hydration on legacy metric

* Remove defintion_description tests

* Update src/metabase/lib/metadata.cljc

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

---------

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Metrics V2] Remove legacy-metric metadata metabase/metabase
1 participant
@snoe