Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether driver supports expression-aggregations before showing Custom Expressions UI #4447

Closed
whitef0x0 opened this issue Feb 27, 2017 · 2 comments
Closed

Check whether driver supports expression-aggregations before showing Custom Expressions UI #4447

whitef0x0 opened this issue Feb 27, 2017 · 2 comments
Assignees
@tlrobinson
Labels
Database/Mongo Priority:P2 Average run of the mill bug Type:Bug Product defects

Comments

@whitef0x0
Copy link

For some reason I'm getting this error Assert failed: (keyword? aggregation-type) when I try to create the Custom Expression "Count / Distinct(ID)".

I can't find anything online about this so I'd figure I'd ask here.

  • Your browser and the version: Chrome 56
  • Your operating system: OSX 10.11.6
  • Your databases: MongoDB 3.0
  • Metabase version: Metabase
  • Metabase hosting environment: Heroku App
  • Metabase internal database: H2
  1. Import Database
  2. Create Question with Expression "Count / Distinct(Field)"
  3. Press Refresh
@tlrobinson
Copy link
Contributor

This works on the Sample Dataset, so I'm guessing it's a MongoDB issue.

@camsaul
Copy link
Member

camsaul commented Feb 27, 2017

We don't currently support Custom Expressions for MongoDB. @tlrobinson are we checking whether the driver supports the expression-aggregations feature?

@camsaul camsaul changed the title Assert failed for Custom Expression Check whether driver supports expression-aggregations before showing Custom Expressions UI Feb 27, 2017
@salsakran salsakran added the Priority:P2 Average run of the mill bug label Feb 28, 2017
tlrobinson added a commit that referenced this issue Mar 1, 2017
@tlrobinson
Only show custom expression aggregation if driver supports feature. R…
1f6d93b 
…esolves #4447
@tlrobinson tlrobinson self-assigned this Mar 1, 2017
@tlrobinson tlrobinson mentioned this issue Mar 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlrobinson tlrobinson

Labels
Database/Mongo Priority:P2 Average run of the mill bug Type:Bug Product defects
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tlrobinson @salsakran @whitef0x0 @camsaul