Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that time series breakouts have continuous grouping values #896

Closed
agilliland opened this issue Aug 20, 2015 · 5 comments · Fixed by #3149
Closed

Ensure that time series breakouts have continuous grouping values #896

agilliland opened this issue Aug 20, 2015 · 5 comments · Fixed by #3149

Comments

@agilliland
Copy link
Contributor

User Story: as a user performing queries that are grouped by a time granularity/extract (day, month, day-of-week, etc) I want to ensure that all possible groupings are reflected in my query result so that I don't misinterpret the data or chart the wrong trend.

This applies specifically to time based groupings, either by time granularity (hour, day, week, month) or by time extract (day-of-week, hour-of-day). In all of these groupings there is an expectation that the result of the query will include a value for each of the continuous grouping values.

For example, if grouping by day for the last 30 days it would be expected that the query would result in 30 rows of data, one for each of the days. If it turns out that the underlying data does not have values for a given grouping we should correct for that and supply an empty value. The same is true for time extract groupings such as day-of-week where it would be strange to run a query grouped by day-of-week and only get back 4 rows of data for (Tuesday, Wednesday, Friday, Sunday).

@camsaul
Copy link
Member

camsaul commented Jun 7, 2016

I have a feeling this will be ultra-hairy trying to deal with all the different possible date bucketing options we have and making it work correctly for different timezones and different databases

@salsakran
Copy link
Contributor

Yeah, sounds messy. It is something a lot of people are working around with left joins to date tables, etc.

@salsakran
Copy link
Contributor

Would this be easier to deal with at the charting level?

I'm assuming it'd be easier to do via post processing query results rather than modifying the query, but it sounds hairy either way.

@salsakran
Copy link
Contributor

It seems like the most efficient place to do this is in the dimension definition in cross-filter.

https://stackoverflow.com/questions/31699747/how-to-deal-with-missing-data-with-crossfilter-and-dc-js

@salsakran salsakran removed this from the 0.19.0 milestone Jul 18, 2016
@salsakran salsakran modified the milestones: 0.20.0, 0.19.0 Jul 18, 2016
@tlrobinson tlrobinson self-assigned this Aug 8, 2016
@tlrobinson tlrobinson mentioned this issue Aug 8, 2016
22 tasks
@tlrobinson
Copy link
Contributor

Implemented in #3149, will be released in v0.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants