Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar — Missing translations #8964

Closed
regrepl opened this issue Nov 18, 2018 · 6 comments · Fixed by #18943
Closed

Calendar — Missing translations #8964

regrepl opened this issue Nov 18, 2018 · 6 comments · Fixed by #18943
Labels
Customization/i18n .Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Milestone

Comments

@regrepl
Copy link

regrepl commented Nov 18, 2018

The Callendar is not translated on charts and tables. That means months name and days. The default setting it's to print name of the month. I know that default format can be globally changed in settings. But still it supposed to be translated.

When editing a table.
2018-11-18 15_06_20-pytanie metabase

And also functions related to sorting by data on charts.
2018-11-18 15_24_24-

I use Polish translation.

⬇️ Please click the 👍 reaction instead of leaving a +1 or update? comment

@ccasado-asac

This comment has been minimized.

@flamber
Copy link
Contributor

flamber commented Jan 31, 2019

There's several missing i18n - also many listed in #6674

Native question filters that are date-based, example Chinese, shows English months, whereas Spanish shows correctly.
This is caused by MomentJS using zh-cn whereas Metabase uses zh for Chinese.
image
image

@jlisyc

This comment has been minimized.

This was referenced Nov 18, 2020
@mazameli mazameli added the Type:Bug Product defects label Nov 18, 2020
@flamber flamber added the .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. label Feb 6, 2021
@flamber
Copy link
Contributor

flamber commented Feb 6, 2021

All calendar widgets (containing month names) are now English, which is a regression since 0.37.0
Fixing this, still needs to address Chinese translations too #8964 (comment)
On 0.36.8:
image
On 0.37.0:
image

@mazameli mazameli added the Priority:P2 Average run of the mill bug label Feb 8, 2021
@zqycn
Copy link

zqycn commented Apr 8, 2021

Calendar has not been translated into Chinese. If I want to translate in the source code, what do I need to do?

@flamber
Copy link
Contributor

flamber commented Apr 8, 2021

@zqycn The calendar has been translated, but there's a problem with Metabase and MomentJS using different locale-dialect - see comment #8964 (comment)

@gusaiani gusaiani changed the title Calendar- Missing translations Calendar — Missing translations Jun 17, 2021
@flamber flamber added this to the 0.42 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customization/i18n .Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants