Fix file loader public path #11206
Merged
Fix file loader public path #11206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2019
|
Any thoughts on how we could test this? Unfortunately I think we'd need to run tests in a real browser. |
tlrobinson
approved these changes
Nov 1, 2019
I think this is really a case where I should have been more careful rather than a failure of tests. But, if there were good tests that'd be great! Maybe we could check that there are no 404's on a test page load? |
|
@tlrobinson do you have an ETA for the next release? |
|
@flipace this fix should be out today or tomorrow. |
5 tasks
|
It seems the bug hasn't been resolved |
|
@shkhaksar You are commenting on a PR that is almost 3 years old. Create a new issue or use the forum for troubleshooting: https://discourse.metabase.com/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My fix in #11174 broke file loading. The presented most obviously as broken fonts.
Here's a history of the issues with this setting:
Situation 1
publicPath: "app/dist/"file-loader files ended up with this public path duplicated. e.g. "app/dist/app/dist/image.svg". This causes 404's when it tries to load these assets.
Situation 2
publicPath: "/app/dist/"Everything works! ...unless you host Metabase with a path prefix. In that case everything breaks.
Situation 3
publicPath: "app/dist/"file-loader's
publicPath: ""The 404's from the first situation disappear, so I assume it works. However, the files are now referenced without "app/dist/" at all! The server returns a 200, but not the file we want.
This PR
publicPath: "app/dist/"file-loader's
publicPath: "./"This seems to actually load the files correctly! It was taken from this Stack Overflow answer.