Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HoneySQL version to latest #14934

Merged
merged 1 commit into from Mar 1, 2021
Merged

Conversation

jeff303
Copy link
Contributor

@jeff303 jeff303 commented Feb 22, 2021

Upgrade HoneySQL version to latest released version (1.0.461)

Modifying ddl.clj to account for a difference in behavior for honeysql.helpers/columns introduced in honeysql 0.9.7 (see long comment)

(sql.qp/->honeysql driver value)))
col-nms (for [column columns]
(sql.qp/->honeysql driver (tx/format-name driver (u/qualified-name column))))]
(-> (apply h/columns (map keyword col-nms)) ; HoneySQL 1.x needs these to be keywords
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change on their side that makes this necessary is, apparently, seancorfield/honeysql#139

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #14934 (ae8d012) into master (6bdd5e0) will decrease coverage by 0.05%.
The diff coverage is 75.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14934      +/-   ##
==========================================
- Coverage   83.87%   83.82%   -0.06%     
==========================================
  Files         389      390       +1     
  Lines       30734    30832      +98     
  Branches     2203     2220      +17     
==========================================
+ Hits        25779    25844      +65     
- Misses       2752     2768      +16     
- Partials     2203     2220      +17     
Impacted Files Coverage Δ
src/metabase/driver/impl.clj 61.19% <0.00%> (ø)
src/metabase/query_processor.clj 89.33% <ø> (+1.33%) ⬆️
backend/mbql/src/metabase/mbql/util.clj 78.73% <31.25%> (-1.59%) ⬇️
src/metabase/driver/h2.clj 88.88% <33.33%> (-3.97%) ⬇️
...ocessor/middleware/validate_temporal_bucketing.clj 56.66% <56.66%> (ø)
src/metabase/util/ssh.clj 93.33% <71.42%> (-5.41%) ⬇️
src/metabase/driver/sql_jdbc/connection.clj 82.43% <75.00%> (-4.24%) ⬇️
...processor/middleware/optimize_temporal_filters.clj 88.11% <88.11%> (ø)
backend/mbql/src/metabase/mbql/schema.clj 99.07% <100.00%> (ø)
src/metabase/driver.clj 89.76% <100.00%> (+0.16%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5dd19...ae8d012. Read the comment docs.

Modifying ddl.clj to account for a difference in behavior for honeysql.helpers/columns introduced in honeysql 0.9.7 (see long comment)
@jeff303 jeff303 marked this pull request as ready for review February 26, 2021 17:51
@jeff303 jeff303 requested a review from camsaul February 26, 2021 17:51
@jeff303 jeff303 merged commit bcdcab2 into master Mar 1, 2021
@jeff303 jeff303 deleted the upgrade-honeysql-version branch March 1, 2021 23:23
@rlotun rlotun added this to the 0.39 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants