Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Oracle SSL tests #15260

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Fix Oracle SSL tests #15260

merged 2 commits into from
Mar 31, 2021

Commits on Mar 24, 2021

  1. Fix Oracle SSL tests 

    Define new test for Oracle SSL connectivity, in oracle_test.clj, similar to how things work in mysql_test.clj

Add new test util macro, with-env-keys-renamed-by, to support running tests with environ keys temporarily renamed

Using new test macro from both MySQL and Oracle SSL connectivity tests

Removing now unneeded be-tests-oracle-ssl-ee CircleCI job

Removing now unneeded test-selector parameter for test-driver orbv in CircleCI config.yml

Updating JVM_OPTS to use a trust store that starts with cacerts and adds the RDS root CA, rather than one only
containing the RDS root CA
    @jeff303
    jeff303 committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    ae2232d View commit details
    Browse the repository at this point in the history

  2. PR feedback: 

    Move bulk of logic from with-env-keys-renamed-by to new do-with-env-keys-renamed-by fn instead, calling that from macro

Change logic of do-with-env-keys-renamed-by to first build the map of renames, then call set/rename-keys with that (for easier capturing of the testing context information)

Switch to u/format-color in tests

Reference new test macro via metabase.test (which imports it)

Use namespace prefixes for the delegated test calls
    @jeff303
    jeff303 committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b5995d0 View commit details
    Browse the repository at this point in the history