Admin graphpage backend #16298
Closed
Admin graphpage backend #16298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16298 +/- ##
===========================================
+ Coverage 38.00% 62.24% +24.23%
===========================================
Files 1116 1598 +482
Lines 30508 65500 +34992
Branches 4634 7226 +2592
===========================================
+ Hits 11596 40773 +29177
- Misses 18216 21579 +3363
- Partials 696 3148 +2452
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
camsaul
reviewed
Jun 8, 2021
src/metabase/api/permissions.clj
Outdated
Comment on lines
29
to
31
| (if (some? group_id) | ||
| (perms/graph group_id) | ||
| (perms/graph))) |
There was a problem hiding this comment.
https://guide.clojure.style/#body-indentation
You have Common Lisp-style if indentation here... indent both the then and else forms just 2 spaces in Clojure
camsaul
reviewed
Jun 8, 2021
camsaul
reviewed
Jun 8, 2021
camsaul
reviewed
Jun 8, 2021
camsaul
approved these changes
Jun 8, 2021
howonlee
force-pushed
the
admin-graphpage-backend
branch
from
042958b
to
71ab082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend bit of #15771