Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to performance troubleshooting guide #17221

Merged
merged 6 commits into from
Jul 28, 2021
Merged

Minor fixes to performance troubleshooting guide #17221

merged 6 commits into from
Jul 28, 2021

Conversation

gvwilson
Copy link
Contributor

Corrects some typos - thanks to @jeff-bruemmer for spotting them.

@gvwilson gvwilson self-assigned this Jul 27, 2021
jeff-bruemmer
jeff-bruemmer approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@jeff-bruemmer jeff-bruemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just two things:

  • See my note about the page title ("Performance" is vague).
  • There's a formatting issue with the "How to fix this" on line 79.

docs/troubleshooting-guide/performance.md Outdated
@@ -1,4 +1,4 @@
## Performance
# Performance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include a sentence explaining what we mean by "Performance"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what we'd say - if we change the title to "Metabase seems to be running slowly" (or whatever grammatical form you choose) will that take care of it?

flamber
flamber approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@flamber flamber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two removing of stuff. Might need to adjust further.

docs/troubleshooting-guide/performance.md Outdated Show resolved Hide resolved
docs/troubleshooting-guide/performance.md Outdated Show resolved Hide resolved
@gvwilson gvwilson merged commit 6bcc6b5 into master Jul 28, 2021
@gvwilson gvwilson deleted the troubleshooting-performance branch July 28, 2021 12:10
gvwilson added a commit that referenced this pull request Aug 3, 2021
@gvwilson @flamber
Minor fixes to performance troubleshooting guide (#17221)
e9b20e1 
* Minor fixes to performance troubleshooting guide

* Update docs/troubleshooting-guide/performance.md

Co-authored-by: flamber <1447303+flamber@users.noreply.github.com>

* Fixing a few small issues with the performance troubleshooting guide.

* Another fix to performance troubleshooting

Co-authored-by: flamber <1447303+flamber@users.noreply.github.com>
jeff-bruemmer added a commit that referenced this pull request Aug 3, 2021
@gvwilson @jeff-bruemmer @flamber
Docs for 40.2 (#17303)
ae75413 
* First editing pass through troubleshooting guide (#17154)

* First editing pass through troubleshooting guide

* Update docs/troubleshooting-guide/application-database.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/application-database.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/application-database.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/timezones.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/application-database.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/datawarehouse.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/docker.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/index.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Moving comma

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Editing FAQ. (#17153)

* Editing FAQ.

- Minor updates to wording.
- Changed a couple of links to point at /learn articles.
- Regularizing title levels.
- Moved all out-of-page links into page foot to simplify consistency checking.

* Update docs/faq/general/do-we-need-a-data-processing-agreement.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/general/does-metabase-do-x.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/general/does-metabase-have-access-to-my-companys-data.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/general/how-do-i-ask-for-help.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/general/is-metabase-508-compliant.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/general/is-metabase-508-compliant.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/general/is-metabase-508-compliant.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/using-metabase/cant-access-data-i-need.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/using-metabase/i-am-not-getting-email-notifications.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/using-metabase/how-do-i-reset-my-password.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/using-metabase/how-do-i-ask-questions.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/using-metabase/how-do-i-answer-questions-with-joins.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/general/supported-browsers.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/general/what-if-i-find-a-bug.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/general/what-languages-can-be-used-with-metabase.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/setup/how-do-i-integrate-with-sso.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/setup/i-am-having-trouble-running-metabase.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/setup/what-is-h2.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/setup/which-databases-does-metabase-support.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/using-metabase/cant-access-data-i-need.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/faq/using-metabase/how-do-i-answer-questions-when-data-is-in-multiple-databases.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* docs - troubleshooting guide: load from h2 (#17209)

* Performance troubleshooting guide (#17174)

* First draft of performance troubleshooting guide.

* Update docs/troubleshooting-guide/performance.md

Co-authored-by: flamber <1447303+flamber@users.noreply.github.com>

* Update docs/troubleshooting-guide/performance.md

Co-authored-by: flamber <1447303+flamber@users.noreply.github.com>

* Update docs/troubleshooting-guide/performance.md

Co-authored-by: flamber <1447303+flamber@users.noreply.github.com>

* Incorporating @flamber suggestions

* Updating troubleshooting guide

Co-authored-by: flamber <1447303+flamber@users.noreply.github.com>

* Minor fixes to performance troubleshooting guide (#17221)

* Minor fixes to performance troubleshooting guide

* Update docs/troubleshooting-guide/performance.md

Co-authored-by: flamber <1447303+flamber@users.noreply.github.com>

* Fixing a few small issues with the performance troubleshooting guide.

* Another fix to performance troubleshooting

Co-authored-by: flamber <1447303+flamber@users.noreply.github.com>

* Troubleshooting guide for sandboxing (#17207)

* Outlining items for troubleshooting guide for sandboxing.

* Update docs/troubleshooting-guide/sandboxing.md

Co-authored-by: flamber <1447303+flamber@users.noreply.github.com>

* Incorporating minor suggestions

* Incorporating comment from @flamber

* Converting sandboxing troubleshooting guide to prose

* Update docs/troubleshooting-guide/sandboxing.md

Co-authored-by: flamber <1447303+flamber@users.noreply.github.com>

* Johannes' fixes

* Update docs/troubleshooting-guide/sandboxing.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/sandboxing.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/sandboxing.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/sandboxing.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/sandboxing.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/sandboxing.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/sandboxing.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Update docs/troubleshooting-guide/sandboxing.md

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* Jeff's edits

Co-authored-by: flamber <1447303+flamber@users.noreply.github.com>
Co-authored-by: Jeff Bruemmer <jeff@metabase.com>

* docs - update troubleshooting section (#17236)

* Troubleshooting sync/fingerprint/scan (#17255)

* First draft of sync/fingerprint/scan troubleshooting

* Merging fixes from @flamber.

* Merging Jeff's suggestions.

Co-authored-by: Jeff Bruemmer <jeff@metabase.com>
Co-authored-by: flamber <1447303+flamber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamber flamber flamber approved these changes

@jeff-bruemmer jeff-bruemmer jeff-bruemmer approved these changes

Assignees

@gvwilson gvwilson

Labels
Type:Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gvwilson @flamber @jeff-bruemmer