Fix SAML login with OpenAM #17785
Merged
Fix SAML login with OpenAM #17785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAM SAMLResponse contains "\r\n" every 76 characters leading our SAML code to think it's not base64-encoded. Fix by relaxing our valid base64 check to ignore all spaces. Fixes #15567
Codecov Report
@@ Coverage Diff @@
## master #17785 +/- ##
==========================================
+ Coverage 62.90% 62.91% +0.01%
==========================================
Files 1630 1631 +1
Lines 66581 66591 +10
Branches 7304 7307 +3
==========================================
+ Hits 41882 41897 +15
+ Misses 21510 21504 -6
- Partials 3189 3190 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
camsaul
approved these changes
Sep 7, 2021
rlotun
added
the
backport
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
OpenAM SAMLResponse contains "\r\n" every 76 characters leading our SAML code to think it's not base64-encoded. Fix by relaxing our valid base64 check to ignore all spaces. Fixes #15567
pawit-metabase
added a commit
that referenced
this pull request
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAM SAMLResponse contains "\r\n" every 76 characters leading our SAML code to think it's not base64-encoded.
Fix by relaxing our valid base64 check to ignore all spaces.
Fixes #15567