Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter for metabase-plugin.yaml files #19240

Merged
merged 1 commit into from Dec 7, 2021

Conversation

jeff303
Copy link
Contributor

@jeff303 jeff303 commented Dec 7, 2021

Add new deps for finding close misspellings of map keys (spell-spec) and printing more readable spec errors (expound)

Adding spec definitions for driver YAML format

Add call to driver YAML validation from verify.clj

Fixing a couple issues in existing drivers found by the validation

Add new deps for finding close misspellings of map keys (spell-spec) and printing more readable spec errors (expound)

Adding spec definitions for driver YAML format

Add call to driver YAML validation from verify.clj

Fixing a couple issues in existing drivers found by the validation
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #19240 (07d3f6f) into master (cfc6599) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19240      +/-   ##
==========================================
- Coverage   64.65%   64.65%   -0.01%     
==========================================
  Files        1894     1894              
  Lines       71300    71300              
  Branches     8441     8441              
==========================================
- Hits        46101    46100       -1     
- Misses      21581    21582       +1     
  Partials     3618     3618              
Flag Coverage Δ
back-end 85.60% <ø> (-0.01%) ⬇️
front-end 42.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/metabase/sync/analyze/fingerprint.clj 87.61% <0.00%> (-0.89%) ⬇️
frontend/src/metabase/lib/greeting.js 69.23% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc6599...07d3f6f. Read the comment docs.

@jeff303 jeff303 requested a review from a team December 7, 2021 21:41
Copy link
Member

@camsaul camsaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

@jeff303 jeff303 merged commit 61828f4 into master Dec 7, 2021
@jeff303 jeff303 deleted the add-linter-for-driver-yaml-files branch December 7, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants