Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repro #20044: "Explore results" shown for no-data users #20197

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

nemanjaglumac
Copy link
Member

Status

PENDING CI && PENDING REVIEW

What does this PR accomplish?

How to test this manually?

  • yarn test-cypress-open
  • frontend/test/metabase/scenarios/native/reproductions/20044-no-data-sees-explore-results.cy.spec.js
  • The test should pass

Additional notes:

Screenshots:

image

@nemanjaglumac nemanjaglumac self-assigned this Feb 2, 2022
@nemanjaglumac nemanjaglumac added the backport Automatically create PR on current release branch on merge label Feb 2, 2022
@nemanjaglumac nemanjaglumac merged commit 660a534 into master Feb 3, 2022
@nemanjaglumac nemanjaglumac deleted the repro/issue_20044 branch February 3, 2022 14:17
nemanjaglumac added a commit that referenced this pull request Feb 3, 2022
)

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .CI & Tests support/Repro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants