Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 backported "Large category picker in bulk filter modal" #24490

Merged

Conversation

metabase-bot[bot]
Copy link
Contributor

@metabase-bot metabase-bot bot commented Aug 1, 2022

@metabase-bot metabase-bot bot enabled auto-merge (squash) August 1, 2022 19:21
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #24490 (e382491) into release-x.44.x (a5c6bf7) will decrease coverage by 0.00%.
The diff coverage is 62.96%.

❗ Current head e382491 differs from pull request most recent head 395b943. Consider uploading reports for the commit 395b943 to get more accurate results

@@                Coverage Diff                 @@
##           release-x.44.x   #24490      +/-   ##
==================================================
- Coverage           64.94%   64.94%   -0.01%     
==================================================
  Files                2742     2745       +3     
  Lines               85048    85063      +15     
  Branches            10456    10458       +2     
==================================================
+ Hits                55232    55241       +9     
- Misses              25537    25547      +10     
+ Partials             4279     4275       -4     
Flag Coverage Δ
front-end 45.92% <62.96%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dals/InlineCategoryPicker/InlineCategoryPicker.tsx 78.37% <33.33%> (+0.11%) ⬆️
...InlineCategoryPicker/LargeCategoryFilterPicker.tsx 60.00% <60.00%> (ø)
...nlineCategoryPicker/SimpleCategoryFilterPicker.tsx 60.00% <60.00%> (ø)
...lineCategoryPicker/InlineCategoryPicker.styled.tsx 100.00% <100.00%> (ø)
...nents/filters/modals/InlineCategoryPicker/utils.ts 100.00% <100.00%> (ø)
...odals/BulkFilterSelect/BulkFilterSelect.styled.tsx 36.36% <0.00%> (-9.10%) ⬇️
...lters/modals/BulkFilterSelect/BulkFilterSelect.tsx 45.45% <0.00%> (-6.07%) ⬇️
.../src/metabase-lib/lib/queries/structured/Filter.ts 76.80% <0.00%> (+2.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@metabase-bot metabase-bot bot merged commit 4bf28e8 into release-x.44.x Aug 1, 2022
@metabase-bot metabase-bot bot deleted the backport-55352abffd8e48e1e2f8bc0aee4054ce02e71353 branch August 1, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant