Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate UserInviteForm to formik #26216

Merged
merged 6 commits into from
Nov 3, 2022
Merged

Migrate UserInviteForm to formik #26216

merged 6 commits into from
Nov 3, 2022

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented Nov 2, 2022

Epic #26178

How to test:

  • npx maildev -s 25 -w 80
  • MB_EMAIL_SMTP_HOST=localhost MB_EMAIL_SMTP_PORT=25 MB_EMAIL_SMTP_USERNAME=admin MB_EMAIL_SMTP_PASSWORD=admin MB_EMAIL_SMTP_SECURITY=none MB_EMAIL_EMAIL_FROM_ADDRESS=mailer@metabase.test yarn dev with a fresh Metabase instance
  • Go to the database step. There should be a new section for inviting a user for database setup.

Screenshot 2022-11-02 at 18 09 16

Screenshot 2022-11-03 at 13 10 24

@ranquild ranquild self-assigned this Nov 2, 2022
@ranquild ranquild requested review from a team and alxnddr November 2, 2022 16:07
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 64.19% // Head: 64.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ca32a2e) compared to base (d9a5708).
Patch coverage: 31.25% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26216   +/-   ##
=======================================
  Coverage   64.19%   64.20%           
=======================================
  Files        3136     3138    +2     
  Lines       92086    92098   +12     
  Branches    11659    11663    +4     
=======================================
+ Hits        59118    59127    +9     
- Misses      28292    28296    +4     
+ Partials     4676     4675    -1     
Flag Coverage Δ
front-end 44.98% <31.25%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...up/components/DatabaseStep/DatabaseStep.styled.tsx 100.00% <ø> (ø)
...ase/setup/components/DatabaseStep/DatabaseStep.tsx 51.72% <ø> (+1.72%) ⬆️
...setup/components/InviteUserForm/InviteUserForm.tsx 26.66% <26.66%> (ø)
...omponents/InviteUserForm/InviteUserForm.styled.tsx 100.00% <100.00%> (ø)
...setup/components/NewsletterForm/NewsletterForm.tsx 90.90% <0.00%> (ø)
...omponents/NewsletterForm/NewsletterForm.styled.tsx 100.00% <0.00%> (ø)
...e/components/FormSubmitButton/FormSubmitButton.tsx 73.33% <0.00%> (+6.66%) ⬆️
...c/metabase/core/components/FormField/FormField.tsx 90.90% <0.00%> (+9.09%) ⬆️
...base/core/hooks/use-form-submit/use-form-submit.ts 66.66% <0.00%> (+26.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ranquild ranquild marked this pull request as draft November 2, 2022 20:53
@ranquild ranquild added the backport Automatically create PR on current release branch on merge label Nov 3, 2022
@ranquild ranquild marked this pull request as ready for review November 3, 2022 11:11
Copy link
Contributor

@iethree iethree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ranquild ranquild merged commit 4a2c6e2 into master Nov 3, 2022
@ranquild ranquild deleted the 26178-form-user-invite branch November 3, 2022 16:48
github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
metabase-bot bot added a commit that referenced this pull request Nov 4, 2022
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants