Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs - filters #26220

Merged
merged 11 commits into from
Nov 9, 2022
Merged

docs - filters #26220

merged 11 commits into from
Nov 9, 2022

Conversation

nllho
Copy link
Contributor

@nllho nllho commented Nov 2, 2022 •
edited
Loading

Super gnarly topic... so many dependencies!

Main changes:

  • Filters troubleshooting: consolidated info with docs.
  • Data reference: moved out of SQL section and brought up to date (it's a great resource for data types, which is the root cause of many issues, filters or otherwise).
  • SQL: updated info on field filters and troubleshooting.

These changes break some links in Learn. I've got them noted down -- will follow up when the 45 docs go out.

Gonna take one more pass just to look at formatting tomorrow, but otherwise this is ready for review.

@nllho nllho added Type:Documentation backport Automatically create PR on current release branch on merge labels Nov 2, 2022
jeff-bruemmer
jeff-bruemmer approved these changes Nov 7, 2022
View reviewed changes
docs/embedding/signed-embedding-parameters.md Outdated Show resolved Hide resolved
docs/exploration-and-organization/data-model-reference.md Outdated Show resolved Hide resolved
docs/troubleshooting-guide/filters.md Outdated Show resolved Hide resolved
docs/troubleshooting-guide/filters.md Outdated Show resolved Hide resolved
docs/troubleshooting-guide/filters.md Outdated Show resolved Hide resolved
docs/troubleshooting-guide/filters.md Show resolved Hide resolved
@nllho nllho merged commit 0337a42 into master Nov 9, 2022
@nllho nllho deleted the docs-filters branch November 9, 2022 16:50
github-actions bot pushed a commit that referenced this pull request Nov 9, 2022
@nllho
docs - filters (#26220)
2e920d8
@metabase-bot metabase-bot bot mentioned this pull request Nov 9, 2022
Merged
metabase-bot bot added a commit that referenced this pull request Nov 9, 2022
@metabase-bot @nllho
docs - filters (#26220) (#26322)
223346e 
Co-authored-by: Natalie <nat@metabase.com>
@WiNloSt WiNloSt mentioned this pull request Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-bruemmer jeff-bruemmer jeff-bruemmer approved these changes

Assignees
No one assigned
Labels
backport Automatically create PR on current release branch on merge Type:Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nllho @jeff-bruemmer