-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the remaning columns that has text type in mysql,mariadb to longtext #26223
Conversation
Codecov ReportBase: 64.28% // Head: 64.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #26223 +/- ##
=======================================
Coverage 64.28% 64.28%
=======================================
Files 3148 3148
Lines 92202 92202
Branches 11699 11699
=======================================
+ Hits 59269 59270 +1
+ Misses 28243 28242 -1
Partials 4690 4690
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tbl-nm | ||
col-nm | ||
exp-type | ||
(get tbl-cols col-nm)))))))))))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this test? It is relatively costly to execute, and we don't run tests like this for all migrations. I feel the same way about convert-text-to-longtext-migration-test
actually.
I can see the need to test more complicated migrations that involve SQL like v45.00-049
but in this case I think your sense check in the PR description is sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point, I'll remove this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approving even if I question whether the test can be deleted.
…ngtext (#26223) * Change the remaning columns that has text type in mysql,mariadb to longtext
…ngtext (#26223) * Change the remaning columns that has text type in mysql,mariadb to longtext
Fixes #26212 and is a follow up of #18749
Sanity check