Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate UserProfileForm to formik #26231

Merged
merged 9 commits into from
Nov 3, 2022
Merged

Migrate UserProfileForm to formik #26231

merged 9 commits into from
Nov 3, 2022

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented Nov 3, 2022

Epic #26178

How to test:

  • Account -> Profile
  • Make sure it is possible to edit and save all the fields

Screenshot 2022-11-03 at 17 21 48

@ranquild ranquild self-assigned this Nov 3, 2022
@ranquild ranquild requested review from a team and alxnddr November 3, 2022 15:23
@ranquild ranquild marked this pull request as ready for review November 3, 2022 15:23
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 64.20% // Head: 64.19% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (21b1443) compared to base (481775a).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26231      +/-   ##
==========================================
- Coverage   64.20%   64.19%   -0.02%     
==========================================
  Files        3144     3146       +2     
  Lines       92116    92123       +7     
  Branches    11676    11683       +7     
==========================================
- Hits        59146    59141       -5     
- Misses      28292    28304      +12     
  Partials     4678     4678              
Flag Coverage Δ
front-end 44.97% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/src/metabase-types/api/mocks/settings.ts 100.00% <ø> (ø)
...d/components/UserPasswordForm/UserPasswordForm.tsx 0.00% <0.00%> (ø)
frontend/src/metabase/account/profile/actions.ts 0.00% <0.00%> (ø)
...ile/components/UserProfileForm/UserProfileForm.tsx 0.00% <0.00%> (ø)
...ofile/containers/UserProfileApp/UserProfileApp.tsx 0.00% <0.00%> (ø)
frontend/src/metabase/account/profile/selectors.ts 0.00% <0.00%> (ø)
frontend/src/metabase/entities/users/forms.js 0.00% <0.00%> (-17.40%) ⬇️
frontend/src/metabase/lib/validate.js 82.35% <0.00%> (-5.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@iethree iethree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂

@ranquild ranquild enabled auto-merge (squash) November 3, 2022 17:27
@ranquild ranquild added the backport Automatically create PR on current release branch on merge label Nov 3, 2022
@ranquild ranquild merged commit ab3b4d0 into master Nov 3, 2022
@ranquild ranquild deleted the 26178-form-user-profile branch November 3, 2022 18:38
github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
metabase-bot bot added a commit that referenced this pull request Nov 4, 2022
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants