Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FormTextArea #26257

Merged
merged 11 commits into from
Nov 4, 2022
Merged

Add FormTextArea #26257

merged 11 commits into from
Nov 4, 2022

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented Nov 4, 2022

Follow up on #26100

@ranquild ranquild self-assigned this Nov 4, 2022
@ranquild ranquild changed the title 26178 form timeline parts Add FormTextArea Nov 4, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 64.19% // Head: 64.18% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2ca5b99) compared to base (25d0d2f).
Patch coverage: 4.54% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26257      +/-   ##
==========================================
- Coverage   64.19%   64.18%   -0.02%     
==========================================
  Files        3146     3149       +3     
  Lines       92123    92143      +20     
  Branches    11683    11687       +4     
==========================================
  Hits        59141    59141              
- Misses      28304    28324      +20     
  Partials     4678     4678              
Flag Coverage Δ
front-end 44.96% <4.54%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ile/components/UserProfileForm/UserProfileForm.tsx 0.00% <0.00%> (ø)
...e/components/FormErrorMessage/FormErrorMessage.tsx 60.00% <ø> (ø)
...c/metabase/core/components/FormInput/FormInput.tsx 100.00% <ø> (ø)
...e/components/FormNumericInput/FormNumericInput.tsx 100.00% <ø> (ø)
...base/core/components/FormTextArea/FormTextArea.tsx 0.00% <0.00%> (ø)
...rc/metabase/core/components/Input/Input.styled.tsx 80.00% <0.00%> (ø)
...ntend/src/metabase/core/components/Input/Input.tsx 66.66% <ø> (ø)
...abase/core/components/TextArea/TextArea.styled.tsx 0.00% <0.00%> (ø)
...src/metabase/core/components/TextArea/TextArea.tsx 0.00% <0.00%> (ø)
...setup/components/InviteUserForm/InviteUserForm.tsx 23.52% <0.00%> (-3.14%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ranquild ranquild added the backport Automatically create PR on current release branch on merge label Nov 4, 2022
@ranquild ranquild merged commit ac42d58 into master Nov 4, 2022
@ranquild ranquild deleted the 26178-form-timeline-parts branch November 4, 2022 20:31
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

@ranquild could not create a backport due to conflicts

@ranquild ranquild added backport Automatically create PR on current release branch on merge and removed backport Automatically create PR on current release branch on merge labels Nov 4, 2022
github-actions bot pushed a commit that referenced this pull request Nov 4, 2022
metabase-bot bot added a commit that referenced this pull request Nov 4, 2022
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant