Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newly created models not appearing in the QB #26275

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented Nov 7, 2022

Fixes #26091
Reproduces #26091

How to test:

Screenshot 2022-11-07 at 21 08 51

@ranquild ranquild self-assigned this Nov 7, 2022
@ranquild ranquild added backport Automatically create PR on current release branch on merge support/Repro labels Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 64.18% // Head: 64.23% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (b49104e) compared to base (84df58a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26275      +/-   ##
==========================================
+ Coverage   64.18%   64.23%   +0.04%     
==========================================
  Files        3149     3148       -1     
  Lines       92150    92177      +27     
  Branches    11687    11698      +11     
==========================================
+ Hits        59151    59214      +63     
+ Misses      28321    28281      -40     
- Partials     4678     4682       +4     
Flag Coverage Δ
front-end 45.06% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/src/metabase/entities/schemas.js 83.33% <100.00%> (ø)
...c/metabase/core/components/TimeInput/TimeInput.tsx 92.10% <0.00%> (-7.90%) ⬇️
...ase/core/components/FormField/FormField.styled.tsx 92.30% <0.00%> (-7.70%) ⬇️
...c/metabase/core/components/FormField/FormField.tsx 84.61% <0.00%> (-6.30%) ⬇️
...llections/components/TimelineCard/TimelineCard.tsx 64.70% <0.00%> (-5.89%) ⬇️
src/metabase/models/query.clj 92.30% <0.00%> (ø)
frontend/src/metabase/entities/timelines.js 16.66% <0.00%> (ø)
frontend/src/metabase-types/api/mocks/timeline.ts 100.00% <0.00%> (ø)
frontend/src/metabase/entities/timeline-events.js 33.33% <0.00%> (ø)
...ontend/src/metabase/components/form/FormWidget.jsx 87.50% <0.00%> (ø)
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ranquild ranquild requested a review from a team November 7, 2022 19:09
@ranquild ranquild marked this pull request as ready for review November 7, 2022 19:09
@ranquild ranquild merged commit 9474085 into master Nov 8, 2022
@ranquild ranquild deleted the 26091-model-invalidate-cache branch November 8, 2022 11:40
metabase-bot bot added a commit that referenced this pull request Nov 8, 2022
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge support/Repro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model list appears empty when creating new question, even though models exist
2 participants